Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github): yarn lint job now fails if formatting was needed #3332

Commits on Jun 19, 2024

  1. ci(github): yarn lint job now fails if formatting was needed

    If someone sends a pull request that isn't formatted according to the
    tools we have in place for auto-format code (ESLint, prettier) then after
    this change the CI will fail and this way we don't end up in a situation
    where running `yarn lint` on the main branch produces a diff of auto-formatted
    code files (which is currently sadly the case).
    
    At the same time as introducing this constraint I'm also applying the automatic
    formatting on the code project wide so that the check can actually pass as
    intended when this change is getting merged.
    
    Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
    petermetz committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    f784791 View commit details
    Browse the repository at this point in the history