-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cleanup-docs): deleted last-remaining deprecated files and folders #3424
Conversation
I don't know why this test and others like it (i.e., exercising similar modules) is failing: https://github.com/hyperledger/cacti/actions/runs/10006846343/job/27663333818. I'm trying the same build in my local setup and it works. Also, I can't find the last time that test worked, because all recent PRs (until recent ones) have skipped these tests. Does anybody have any ideas? |
@VRamakrishna It fails with downloading some java dependencies from the jfrog artifactory. I've seen similar failures before that turned out to be just outages on the side of jfrog where the CI job failed to get the dependencies because their (JFrog's) servers were down. Other times GitHub's data centers have some networking issue and it fails to download it just because the connection from Azure to JFrog is broken and you locally can still install things because the connection between your house/office to JFrog is working still. One more thing to consider and try: wipe your local maven/gradle dependency caches and try again the build locally. It could be that on your machine it works only because past successful builds have cached the dependencies but the CI with the freshly provisioned ephemeral workers that run the jobs do not have the cache pre-warmed and so it could be failing because it's trying to download the dependency while your personal computer isn't fetching it at all. |
@petermetz I upgraded the version of the offending package (which in turn had a dependency that Maven seems to have removed.) The tests are re-running now. If everything works, I'll rebase and merge. |
@VRamakrishna Oh, that's an interesting one. My charitable interpretation there would be that the versions that got removed had some very severe vulnerability in them and this is how they forced an upgrade for everyone, but I'm not aware of any CVEs like that right now so who knows why would they just remove specific versions of dependencies. Thank you for fixing it! |
Reflected pending changes to the new docs folder. Updated com.jfrog.artifactory versions to fix missing dependency. Signed-off-by: VRamakrishna <vramakr2@in.ibm.com>
81482ae
into
hyperledger-cacti:main
@VRamakrishna How did you manage to merge this with the freeze in effect? I wonder if the mergefreeze check is buggy. |
docs
folder is the sole repository for Cacti documentation.com.jfrog.artifactory
versions inbuild.gradle
files as the old version had a missing dependency and was causing build failures.Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.