Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github): workflow to ensure PR commit parity #3436

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

jagpreetsinghsasan
Copy link
Contributor

Commit to be reviewed

ci(github): workflow to ensure PR commit parity

Primary Changes
---------------
1. Added a script which ensures PR body and commit message
   parity

Changes needed to incorporate 1)
--------------------------------
2. Added a new workflow to enable the same

Fixes #2214

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

    Primary Changes
    ---------------
    1. Added a script which ensures PR body and commit message
       parity

    Changes needed to incorporate 1)
    --------------------------------
    2. Added a new workflow to enable the same

Fixes hyperledger-cacti#2214

Signed-off-by: jagpreetsinghsasan <jagpreet.singh.sasan@accenture.com>
@petermetz petermetz merged commit 2ef8324 into hyperledger-cacti:main Aug 8, 2024
140 of 143 checks passed
@petermetz petermetz deleted the feature-2214a branch August 8, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci(github): workflow to ensure PR description & commit message parity
3 participants