Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github): fix keychain-aws-sm no code coverage files/dir found #3456

Conversation

petermetz
Copy link
Contributor

@petermetz petermetz commented Aug 3, 2024

  1. The Jest test execution was turned off for the AWS SM keychain plugin
    for some reason so this PR enables it back and while at it
  2. I also refactored one of the test cases to have less linter warnings
    about us casting to any.
  3. And on top of that I also migrated one of the test cases to Jest from
    TAP/tape so that we are making some progress with the test coverage at
    the same time.

One more notable thing is that I refactored the negative test assertions
while migrating to Jest so the test case now uses Jest native assertions
to check what exactly the error message returned by the API call for
deleting a non-existent item looks like. This is an example of the
refactoring that this issue is about:
https://github.com/hyperledger/cacti/issues/3455

Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com

Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1. The Jest test execution was turned off for the AWS SM keychain plugin
for some reason so this PR enables it back and while at it
2. I also refactored one of the test cases to have less linter warnings
about us casting to `any`.
3. And on top of that I also migrated one of the test cases to Jest from
TAP/tape so that we are making some progress with the test coverage at
the same time.

One more notable thing is that I refactored the negative test assertions
while migrating to Jest so the test case now uses Jest native assertions
to check what exactly the error message returned by the API call for
deleting a non-existent item looks like. This is an example of the
refactoring that this issue is about:
https://github.com/hyperledger/cacti/issues/3455

Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
@petermetz petermetz force-pushed the ci-plugin-keychain-aws-sm-fix-no-files-found-codecov-dir branch from d0c7f7e to 6d2ca6c Compare August 8, 2024 23:42
@petermetz petermetz merged commit 5f70aae into hyperledger-cacti:main Aug 9, 2024
144 of 149 checks passed
@petermetz petermetz deleted the ci-plugin-keychain-aws-sm-fix-no-files-found-codecov-dir branch August 9, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants