ci(github): fix keychain-aws-sm no code coverage files/dir found #3456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
requested review from
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna,
sandeepnRES and
outSH
as code owners
outSH
approved these changes
Aug 6, 2024
1. The Jest test execution was turned off for the AWS SM keychain plugin for some reason so this PR enables it back and while at it 2. I also refactored one of the test cases to have less linter warnings about us casting to `any`. 3. And on top of that I also migrated one of the test cases to Jest from TAP/tape so that we are making some progress with the test coverage at the same time. One more notable thing is that I refactored the negative test assertions while migrating to Jest so the test case now uses Jest native assertions to check what exactly the error message returned by the API call for deleting a non-existent item looks like. This is an example of the refactoring that this issue is about: https://github.com/hyperledger/cacti/issues/3455 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
force-pushed
the
ci-plugin-keychain-aws-sm-fix-no-files-found-codecov-dir
branch
from
d0c7f7e
to
6d2ca6c
Compare
petermetz
deleted the
ci-plugin-keychain-aws-sm-fix-no-files-found-codecov-dir
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for some reason so this PR enables it back and while at it
about us casting to
any.TAP/tape so that we are making some progress with the test coverage at
the same time.
One more notable thing is that I refactored the negative test assertions
while migrating to Jest so the test case now uses Jest native assertions
to check what exactly the error message returned by the API call for
deleting a non-existent item looks like. This is an example of the
refactoring that this issue is about:
https://github.com/hyperledger/cacti/issues/3455
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com