feat(corda): dockerfile update to include cordapps #3480
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...es/cactus-plugin-ledger-connector-corda/src/main/typescript/plugin-ledger-connector-corda.ts
Fixed
Show fixed
Hide fixed
...nnector-corda/src/test/typescript/integration/corda-v5-x/corda-v5-cordapp-deployment.test.ts
Dismissed
Show dismissed
Hide dismissed
adrianbatuto
force-pushed
the
adrianbatuto/issue3442
branch
3 times, most recently
from
09235c6
to
ee12441
Compare
petermetz
requested changes
Aug 26, 2024
There was a problem hiding this comment.
@adrianbatuto Please fix the lint check
Off-topic suggestion for this PR and also in general: the way GitHub works is that while the PR is in draft stage it doesn't ping me that I need to review it so I never notice it. If you set the PR to "ready for review" (so move it from draft to ready) then it shows up on my queue and then there's a higher chance that it will get reviewed quicker!
adrianbatuto
force-pushed
the
adrianbatuto/issue3442
branch
2 times, most recently
from
c5b8ba5
to
0081177
Compare
adrianbatuto
requested review from
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna,
sandeepnRES and
outSH
as code owners
petermetz
approved these changes
Aug 27, 2024
jagpreetsinghsasan
requested changes
Aug 29, 2024
tools/docker/corda-all-in-one/corda-v5/cordapps-deployment/healthcheck.sh
Show resolved
Hide resolved
tools/docker/corda-all-in-one/corda-v5/cordapps-deployment/healthcheck.sh
Outdated
Show resolved
Hide resolved
|
Adding to the above points
|
adrianbatuto
force-pushed
the
adrianbatuto/issue3442
branch
from
0081177
to
e460a4f
Compare
Primary Changes ---------------- 1. Created AIO to support the deployment of Cordapps in Corda 5 2. Created corda-v5-cordapp-deployment.test.ts to test the AIO Fixes hyperledger-cacti#3442 Signed-off-by: adrianbatuto <adrian.batuto@accenture.com>
adrianbatuto
force-pushed
the
adrianbatuto/issue3442
branch
from
e460a4f
to
6fed945
Compare
|
@jagpreetsinghsasan @adrianbatuto Let's re-open this PR once the pre-conditions are met, closing it for now. Also, one more thing: Please place some links here in the comments for the issue+PR of the mentioned dependencies (flow status PR) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit to be reviewed
feat(corda): dockerfile update to include cordapps
Fixes #3442
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.