Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix all broken validations in packages folder #3495

Closed
wants to merge 2 commits into from
Closed

test: fix all broken validations in packages folder #3495

wants to merge 2 commits into from

Commits on Sep 21, 2024

  1. test: refactor jest test negative test cases - phase 1 

    Primary Changes
---------------
1. Refactored all remaining negative test case exception assertions under cacti/packages
Removed try-catch blocks, replaced with declarations through jest-extended's own API.

Fixes hyperledger-cacti#3483

Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
    @ashnashahgrover
    ashnashahgrover committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    f2c27ea View commit details
    Browse the repository at this point in the history

  2. test: fix all broken validations in packages folder  

    Primary Changes
---------------
1. Fixed broken assertions in deploy-contract-from-json-xdai.test.ts so they assert that
“Nonce is too low” as expected.

Fixes hyperledger-cacti#3493

Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
    @ashnashahgrover
    ashnashahgrover committed Sep 21, 2024
    Configuration menu
    Copy the full SHA
    1e35f55 View commit details
    Browse the repository at this point in the history