Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cmd-socketio-server): move to examples as deprecated #3541

Merged

Conversation

outSH
Copy link
Contributor

@outSH outSH commented Sep 12, 2024

  • Move cmd-socketio-server from packages/cactus-cmd-socketio-server to examples/cactus-common-example-server/.
  • This package is now meant only as a setup component for some example apps and is not meant to be used in the production code anymore. Package should be removed in the future after sample apps are refactored to work without it.

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

- Move `cmd-socketio-server` from `packages/cactus-cmd-socketio-server` to
  `examples/cactus-common-example-server/`.
- This package is now meant only as a setup component for some example apps
  and is not meant to be used in the production code anymore. Package should
  be removed in the future after sample apps are refactored to work without it.

Signed-off-by: Michal Bajer <michal.bajer@fujitsu.com>
@petermetz petermetz merged commit 4de8069 into hyperledger-cacti:main Sep 13, 2024
149 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants