-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add design document for fpc with cc-tools #773
Add design document for fpc with cc-tools #773
Conversation
6bab6b2
to
19a889b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting this great proposal! I highly support this work!
Please see a few cosmetic comments.
I have looked at the design document. These are my comments:
-In this sentence
What does that 2 mean? |
f9dfe23
to
2ce4558
Compare
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
2ce4558
to
cdf1eca
Compare
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
720db21
to
51b6004
Compare
46cdeb0
to
735676d
Compare
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
735676d
to
3f75074
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
90f5433
to
1474dfa
Compare
Signed-off-by: osamamagdy <osamamagdy174@gmail.com>
1474dfa
to
4a5744e
Compare
This PR adds the design document and how we approach the integration project between CC-Tools and FPC