Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of a base and build image in Dockerfile #125

Merged
merged 4 commits into from
May 23, 2024

Conversation

EnriqueL8
Copy link
Contributor

@EnriqueL8 EnriqueL8 commented May 16, 2024

Add a BASE_IMAGE and BUILD_IMAGE argument to Dockerfile and Makefile docker

Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
Signed-off-by: Enrique Lacal <enrique.lacal@kaleido.io>
@EnriqueL8 EnriqueL8 changed the title Allow configuration of a base image in Dockerfile Allow configuration of a base and build image in Dockerfile May 23, 2024
@peterbroadhurst peterbroadhurst merged commit 3a3c7af into main May 23, 2024
3 checks passed
@peterbroadhurst peterbroadhurst deleted the base_image branch May 23, 2024 14:04
EnriqueL8 pushed a commit to kaleido-io/firefly-fabconnect that referenced this pull request May 28, 2024
Allow configuration of a base and build image in Dockerfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants