Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify transaction types in genesis files #1491

Open
skhoroshavin opened this issue Aug 10, 2020 · 0 comments
Open

Verify transaction types in genesis files #1491

skhoroshavin opened this issue Aug 10, 2020 · 0 comments

Comments

@skhoroshavin
Copy link
Contributor

skhoroshavin commented Aug 10, 2020

It turned out Indy Node/Plenum doesn't verify transaction types in genesis transaction. Given that there are actually two genesis transactions files in Indy Plenum (pool and domain) it can lead to situations when those files are mixed up and Indy Node doesn't give any warning. It might be also sensible to perform some additional validations of those transactions (for example - static validation part)

More details can be found here: https://sovrin.atlassian.net/browse/SN-18

Acceptance criteria

  • When building ledgers from genesis transaction files Indy Plenum/Node should perform at least minimal validation of these transactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants