diff --git a/django_app/redbox_app/redbox_core/consumers.py b/django_app/redbox_app/redbox_core/consumers.py index 87f46126e..75a4dcbea 100644 --- a/django_app/redbox_app/redbox_core/consumers.py +++ b/django_app/redbox_app/redbox_core/consumers.py @@ -81,7 +81,6 @@ async def receive(self, text_data=None, bytes_data=None): if session_id := data.get("sessionId"): session = await Chat.objects.aget(id=session_id) - logger.info("updating: chat_backend=%s -> ai_settings=%s", session.chat_backend, chat_backend) session.chat_backend = chat_backend session.temperature = temperature await session.asave() diff --git a/django_app/tests/conftest.py b/django_app/tests/conftest.py index 3d800a1cd..44b987d0f 100644 --- a/django_app/tests/conftest.py +++ b/django_app/tests/conftest.py @@ -64,9 +64,8 @@ def _collect_static(): call_command("collectstatic", "--no-input") -@pytest.mark.django_db() @pytest.fixture(autouse=True) -def default_ai_settings(): +def default_ai_settings(db): # noqa: ARG001 gpt_4o, _ = ChatLLMBackend.objects.get_or_create(name="gpt-4o", provider="azure_openai", is_default=True) ai_settings, _ = AISettings.objects.get_or_create(label="default", chat_backend=gpt_4o) return ai_settings @@ -105,6 +104,11 @@ def alice(create_user): ) +@pytest.fixture() +def chat_with_alice(alice): + return Chat.objects.create(name="a chat", user=alice) + + @pytest.fixture() def bob(create_user): return create_user("bob@example.com", "2000-01-01") diff --git a/django_app/tests/test_consumers.py b/django_app/tests/test_consumers.py index 10178af95..207771836 100644 --- a/django_app/tests/test_consumers.py +++ b/django_app/tests/test_consumers.py @@ -420,25 +420,22 @@ async def test_chat_consumer_with_explicit_no_document_selected_error( @pytest.mark.django_db() @pytest.mark.asyncio() async def test_chat_consumer_get_ai_settings( - alice: User, mocked_connect_with_explicit_no_document_selected_error: Connect + chat_with_alice: Chat, mocked_connect_with_explicit_no_document_selected_error: Connect ): with patch( "redbox_app.redbox_core.consumers.ChatConsumer.redbox.graph", new=mocked_connect_with_explicit_no_document_selected_error, ): communicator = WebsocketCommunicator(ChatConsumer.as_asgi(), "/ws/chat/") - communicator.scope["user"] = alice + communicator.scope["user"] = chat_with_alice.user connected, _ = await communicator.connect() assert connected - chat = Chat(name="a chat", user=alice) - - await chat.asave() - - ai_settings = await ChatConsumer.get_ai_settings(chat) + ai_settings = await ChatConsumer.get_ai_settings(chat_with_alice) assert ai_settings.chat_map_question_prompt == CHAT_MAP_QUESTION_PROMPT - assert ai_settings.chat_backend.name == chat.chat_backend_id + assert ai_settings.chat_backend.name == chat_with_alice.chat_backend.name + assert ai_settings.chat_backend.provider == chat_with_alice.chat_backend.provider assert not hasattr(ai_settings, "label") # Close