From e246653dfe73e595961f4e737b1cd6d31e67a0d0 Mon Sep 17 00:00:00 2001 From: gecBurton Date: Fri, 18 Oct 2024 12:26:26 +0100 Subject: [PATCH 1/2] fixed metadata error --- redbox-core/redbox/loader/loaders.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/redbox-core/redbox/loader/loaders.py b/redbox-core/redbox/loader/loaders.py index 1445eb3ee..21f1f5345 100644 --- a/redbox-core/redbox/loader/loaders.py +++ b/redbox-core/redbox/loader/loaders.py @@ -173,10 +173,12 @@ def create_file_metadata(self, page_content: str, metadata: dict[str, Any]) -> d except ConnectionError as e: logger.warning(f"Retrying due to HTTPError {e}") except json.JSONDecodeError: + logger.error("failed to encode metadata into json") # replace with fail safe metadata - return None + return {} except Exception as e: - raise Exception(f"Some error happened in metadata extraction. {e}") + logger.error(f"Unhandled error happened in metadata extraction. {e}") + return {} def coerce_to_string_list(input_data: str | list[Any]) -> list[str]: From 007d2678b84d8a86792571397b1e188cb307e7c4 Mon Sep 17 00:00:00 2001 From: gecBurton Date: Fri, 18 Oct 2024 12:27:57 +0100 Subject: [PATCH 2/2] fixed metadata error --- redbox-core/redbox/loader/loaders.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/redbox-core/redbox/loader/loaders.py b/redbox-core/redbox/loader/loaders.py index 21f1f5345..18fadef3e 100644 --- a/redbox-core/redbox/loader/loaders.py +++ b/redbox-core/redbox/loader/loaders.py @@ -175,10 +175,10 @@ def create_file_metadata(self, page_content: str, metadata: dict[str, Any]) -> d except json.JSONDecodeError: logger.error("failed to encode metadata into json") # replace with fail safe metadata - return {} + return metadata except Exception as e: logger.error(f"Unhandled error happened in metadata extraction. {e}") - return {} + return metadata def coerce_to_string_list(input_data: str | list[Any]) -> list[str]: