refactor: remove double nested behavior for early return

Author: iBotPeaches

app/Http/Livewire/UpdatePlayerPanel.php

@@ -34,34 +34,35 @@ public function render(): View
             $color = 'is-dark';
             $message = 'Profile was recently updated. Check back soon.';
         } else {
-            if ($this->runUpdate) {
-                try {
-                    DB::transaction(function () use ($cacheKey) {
-                        $cooldownMinutes = (int) config('services.halodotapi.cooldown');
+            if (! $this->runUpdate) {
+                return view('livewire.update-player-panel', [
+                    'color' => 'is-info',
+                    'message' => 'Checking for updated stats.'
+                ]);
+            }
+
+            try {
+                DB::transaction(function () use ($cacheKey) {
+                    $cooldownMinutes = (int)config('services.halodotapi.cooldown');
 
-                        $this->player->updateFromHaloDotApi();
+                    $this->player->updateFromHaloDotApi();
+                    if (empty($this->player->xuid)) {
+                        $this->player->syncXuidFromXboxApi();
+                        $this->player->saveOrFail();
+                    }
 
-                        // For some accounts, we don't have an xuid. We will grab them with this fallback
-                        if (empty($this->player->xuid)) {
-                            $this->player->syncXuidFromXboxApi();
-                            $this->player->saveOrFail();
-                        }
-                        Cache::put($cacheKey, true, now()->addMinutes($cooldownMinutes));
-                        $this->emitToRespectiveComponent();
-                    });
-                } catch (RequestException $exception) {
-                    $color = 'is-danger';
-                    $message = $exception->getCode() === 429
-                        ? 'Rate Limit Hit :( - Try later.'
-                        : 'Oops - something went wrong.';
-                } catch (\Throwable $exception) {
-                    Log::error($exception->getMessage());
-                    $color = 'is-danger';
-                    $message = 'Oops - something went wrong.';
-                }
-            } else {
-                $color = 'is-info';
-                $message = 'Checking for updated stats.';
+                    Cache::put($cacheKey, true, now()->addMinutes($cooldownMinutes));
+                    $this->emitToRespectiveComponent();
+                });
+            } catch (RequestException $exception) {
+                $color = 'is-danger';
+                $message = $exception->getCode() === 429
+                    ? 'Rate Limit Hit :( - Try later.'
+                    : 'Oops - something went wrong.';
+            } catch (\Throwable $exception) {
+                Log::error($exception->getMessage());
+                $color = 'is-danger';
+                $message = 'Oops - something went wrong.';
             }
         }