From 164f9c7c20237cdcee411953b72102cb67aff855 Mon Sep 17 00:00:00 2001
From: Darren Lines <darren@darrenlines.uk>
Date: Sun, 2 Jun 2024 18:54:28 +0100
Subject: [PATCH] Consolidate the old `PIDProfile` and `Profile` in to `Control
 Profile`

- Consolidate the old `PIDProfile` and `Profile` in to `Control Profile`
- Improve consistency by maintaining the order of `Control Profile`, `Mixer Profile`, and `Battery Profile`.
- Added missing `Set Heading Target` operator to the programming UI
---
 index.html                       | 20 ++++++++++----------
 js/logicConditionOperantTypes.js |  4 ++--
 js/logicConditionOperators.js    |  9 ++++++++-
 js/msp/MSPHelper.js              |  2 +-
 locale/en/messages.json          | 10 +++++-----
 src/css/main.css                 |  4 ++--
 6 files changed, 28 insertions(+), 21 deletions(-)

diff --git a/index.html b/index.html
index e41c0f288..651930611 100644
--- a/index.html
+++ b/index.html
@@ -95,16 +95,6 @@ <h1 class="modal__title modal__title" data-i18n="appUpdateNotificationHeader"></
                             <div class="legend" i18n="sensorDataFlashFreeSpace"></div>
                         </li>
                     </ul>
-                    <div id="mixer_profile_change">
-                        <div class="dropdown  dropdown-dark">
-                            <form name="mixer-profile-change" id="mixer-profile-change">
-                                <select class="dropdown-select" id="mixerprofilechange">
-                                <option value="0" i18n="mixerProfile1"></option>
-                                <option value="1" i18n="mixerProfile2"></option>
-                                </select>
-                            </form>
-                        </div>
-                    </div>
                     <div id="profile_change">
                         <div class="dropdown dropdown-dark">
                             <form name="profile-change" id="profile-change">
@@ -117,6 +107,16 @@ <h1 class="modal__title modal__title" data-i18n="appUpdateNotificationHeader"></
                             </form>
                         </div>
                     </div>
+                    <div id="mixer_profile_change">
+                        <div class="dropdown  dropdown-dark">
+                            <form name="mixer-profile-change" id="mixer-profile-change">
+                                <select class="dropdown-select" id="mixerprofilechange">
+                                <option value="0" i18n="mixerProfile1"></option>
+                                <option value="1" i18n="mixerProfile2"></option>
+                                </select>
+                            </form>
+                        </div>
+                    </div>
                     <div id="battery_profile_change">
                         <div class="dropdown dropdown-dark">
                             <form name="battery-profile-change" id="battery-profile-change">
diff --git a/js/logicConditionOperantTypes.js b/js/logicConditionOperantTypes.js
index 98ba42ff3..99599ca69 100644
--- a/js/logicConditionOperantTypes.js
+++ b/js/logicConditionOperantTypes.js
@@ -53,13 +53,13 @@ const OPERAND_TYPES = {
             30: "CRSF SNR",
             31: "GPS Valid Fix",
             32: "Loiter Radius [cm]",
-            33: "Active PIDProfile",
+            33: "Active Control Profile",
             34: "Battery cells",
             35: "AGL status [0/1]",
             36: "AGL [cm]",
             37: "Rangefinder [cm]",
             38: "Active MixerProfile",
-            39: "MixerTransition Active",
+            39: "Mixer Transition Active",
             40: "Yaw [deg]",
             41: "FW Land State"
         }
diff --git a/js/logicConditionOperators.js b/js/logicConditionOperators.js
index 76e515ddd..115affbd2 100644
--- a/js/logicConditionOperators.js
+++ b/js/logicConditionOperators.js
@@ -242,6 +242,13 @@ const LOGIC_OPERATORS = {
         output: "boolean"
     },
 
+    39: {
+        name: "Set Heading Target",
+        operandType: "Set Flight Parameter",
+        hasOperand: [true, false],
+        output: "raw"
+    },
+
     41: {
         name: "Override Loiter Radius",
         operandType: "Set Flight Parameter",
@@ -249,7 +256,7 @@ const LOGIC_OPERATORS = {
         output: "boolean"
     },
     42: {
-        name: "Set Profile",
+        name: "Set Control Profile",
         operandType: "Set Flight Parameter",
         hasOperand: [true, false],
         output: "boolean"
diff --git a/js/msp/MSPHelper.js b/js/msp/MSPHelper.js
index 613fb7445..383b99bbd 100644
--- a/js/msp/MSPHelper.js
+++ b/js/msp/MSPHelper.js
@@ -1319,7 +1319,7 @@ var mspHelper = (function () {
                 console.log('Looptime saved');
                 break;
             case MSPCodes.MSP_SET_RESET_CURR_PID:
-                console.log('Current PID profile reset');
+                console.log('Current Control profile reset');
                 break;
             case MSPCodes.MSP_SET_3D:
                 console.log('3D settings saved');
diff --git a/locale/en/messages.json b/locale/en/messages.json
index c5e53172e..031f2be01 100644
--- a/locale/en/messages.json
+++ b/locale/en/messages.json
@@ -5132,10 +5132,10 @@
         "message": "Enable if the motor direction is reversed and the props are mounted in the opposite direction."
     },
     "mixer_pid_profile_linking": {
-        "message": "PID Profile will use same index as Mixer Profile index"
+        "message": "Control Profile will use same index as Mixer Profile index"
     },
     "mixer_pid_profile_linking_hint": {
-        "message": "mixer_pid_profile_linking: Enable on both Mixer Profile if you want PID Profile switching handled by Mixer Profile switching(Recommend in vtol/mixed plaform type setup)"
+        "message": "mixer_pid_profile_linking: Enable on both Mixer Profile if you want Control Profile switching handled by Mixer Profile switching(Recommend in vtol/mixed plaform type setup)"
     },
     "blackboxFields": {
         "message": "Blackbox fields"
@@ -5459,13 +5459,13 @@
         "message": "Mixer Profile 2"
     },
     "sensorProfile1": {
-        "message": "PID Profile 1"
+        "message": "Control Profile 1"
     },
     "sensorProfile2": {
-        "message": "PID Profile 2"
+        "message": "Control Profile 2"
     },
     "sensorProfile3": {
-        "message": "PID Profile 3"
+        "message": "Control Profile 3"
     },
     "sensorBatteryProfile1": {
         "message": "Battery Profile 1"
diff --git a/src/css/main.css b/src/css/main.css
index 9baa8f7b1..06cc62f70 100644
--- a/src/css/main.css
+++ b/src/css/main.css
@@ -1700,7 +1700,7 @@ dialog {
 
 }
 
-#mixer_profile_change {
+#profile_change {
     color: white;
     margin-top: 16px;
     width: 130px;
@@ -1709,7 +1709,7 @@ dialog {
     line-height: 12px;
 }
 
-#profile_change {
+#mixer_profile_change {
     color: white;
     margin-top: 16px;
     width: 130px;