support some edge cases that svcs supports

Author: nick4598

packages/transformer/src/IModelTransformer.ts

@@ -247,6 +247,23 @@ export interface IModelTransformOptions {
    * @default "reject"
    */
   branchRelationshipDataBehavior?: "unsafe-migrate" | "reject";
+
+  /**
+   * The forward sync 'version' to set on the scoping ESA @see ExternalSourceAspectProps upon startup, if the version property on the scoping ESA is undefined or empty string.
+   * @note This option is not without risk! You must also set @see branchRelationshipDataBehavior to "unsafe-migrate".
+   * @note This value is ignored if the version property on the scoping ESA is NOT undefined or empty string.
+   * @default ""
+   */
+  unsafeSyncVersion?: string;
+
+  /**
+   * The reverse sync version to set on the scoping ESA @see TargetScopeProvenanceJsonProps upon startup, if the reverseSync property on the scoping ESA is undefined or empty string.
+   * @note This option is not without risk! You must also set @see branchRelationshipDataBehavior to "unsafe-migrate".
+   * @note This value is ignored if the reverseSyncVersion property on the scoping ESA is NOT undefined or empty string.
+   * @default ""
+   */
+  unsafeReverseSyncVersion?: string;
+
   /**
    * Skip propagating changes made to the root subject, dictionaryModel and IModelImporter._realityDataSourceLinkPartitionStaticId (0xe)
    * @default false
@@ -779,7 +796,9 @@ export class IModelTransformer extends IModelExportHandler {
     );
     Logger.logInfo(
       TransformerLoggerCategory.IModelImporter,
-      `this.importer.autoExtendProjectExtents=${JSON.stringify(this.importer.options.autoExtendProjectExtents)}`
+      `this.importer.autoExtendProjectExtents=${JSON.stringify(
+        this.importer.options.autoExtendProjectExtents
+      )}`
     );
     Logger.logInfo(
       TransformerLoggerCategory.IModelImporter,
@@ -1119,6 +1138,52 @@ export class IModelTransformer extends IModelExportHandler {
               reverseSyncVersion: "",
             }
           : undefined;
+
+      if (this._options.branchRelationshipDataBehavior === "unsafe-migrate") {
+        // Only propagate the unsafeSyncVersion and unsafeReverseSyncVersion if the currently stored versions are empty string.
+        // Note that in the unsafe-migrate case these may have just been set to empty string, if they were previously undefined.
+        aspectProps.version =
+          aspectProps.version === ""
+            ? this._options.unsafeSyncVersion ?? ""
+            : aspectProps.version;
+        aspectProps.jsonProperties!.reverseSyncVersion =
+          aspectProps.jsonProperties!.reverseSyncVersion === ""
+            ? this._options.unsafeReverseSyncVersion ?? ""
+            : aspectProps.jsonProperties!.reverseSyncVersion;
+      }
+
+      /**
+       * This case will only be hit when:
+       *  - first transformation was performed on pre-fedguid transformer.
+       *  - a second processAll transformation was performed on the same target-source iModels post-fedguid transformer.
+       *  - change processing was invoked on for the second 'initial' transformation.
+       *  NOTE: This case likely does not exist anymore, but we will keep it just to be sure.
+       */
+
+      if (
+        aspectProps.jsonProperties !== undefined &&
+        this._options.branchRelationshipDataBehavior === "unsafe-migrate"
+      ) {
+        if (
+          aspectProps.jsonProperties.pendingReverseSyncChangesetIndices ===
+          undefined
+        ) {
+          Logger.logWarning(
+            loggerCategory,
+            "Property pendingReverseSyncChangesetIndices missing on the jsonProperties of the scoping ESA. Setting to []."
+          );
+          aspectProps.jsonProperties.pendingReverseSyncChangesetIndices = [];
+        }
+        if (
+          aspectProps.jsonProperties.pendingSyncChangesetIndices === undefined
+        ) {
+          Logger.logWarning(
+            loggerCategory,
+            "Property pendingSyncChangesetIndices missing on the jsonProperties of the scoping ESA. Setting to []."
+          );
+          aspectProps.jsonProperties.pendingSyncChangesetIndices = [];
+        }
+      }
     }
 
     this._targetScopeProvenanceProps =
@@ -1550,13 +1615,9 @@ export class IModelTransformer extends IModelExportHandler {
 
   /** Returns true if a change within sourceElement is detected.
    * @param sourceElement The Element from the source iModel
-   * @param targetElementId The Element from the target iModel to compare against.
    * @note A subclass can override this method to provide custom change detection behavior.
    */
-  protected hasElementChanged(
-    sourceElement: Element,
-    _targetElementId: Id64String
-  ): boolean {
+  protected hasElementChanged(sourceElement: Element): boolean {
     if (this._sourceChangeDataState === "no-changes") return false;
     if (this._sourceChangeDataState === "unconnected") return true;
     nodeAssert(
@@ -1882,11 +1943,7 @@ export class IModelTransformer extends IModelExportHandler {
       }
     }
 
-    if (
-      Id64.isValid(targetElementId) &&
-      !this.hasElementChanged(sourceElement, targetElementId)
-    )
-      return;
+    if (!this.hasElementChanged(sourceElement)) return;
 
     this.collectUnmappedReferences(sourceElement);
 
@@ -2848,6 +2905,12 @@ export class IModelTransformer extends IModelExportHandler {
     )) {
       relationshipECClassIds.add(row.ECInstanceId);
     }
+    const elementECClassIds = new Set<string>();
+    for await (const row of this.sourceDb.createQueryReader(
+      "SELECT ECInstanceId FROM ECDbMeta.ECClassDef where ECInstanceId IS (BisCore.Element)"
+    )) {
+      elementECClassIds.add(row.ECInstanceId);
+    }
 
     // For later use when processing deletes.
     const alreadyImportedElementInserts = new Set<Id64String>();
@@ -2900,7 +2963,12 @@ export class IModelTransformer extends IModelExportHandler {
           change.Scope.Id === this.targetScopeElementId
         ) {
           elemIdToScopeEsa.set(change.Element.Id, change);
-        } else if (changeType === "Inserted" || changeType === "Updated")
+        } else if (
+          changeType === "Inserted" ||
+          (changeType === "Updated" &&
+            change.ECClassId !== undefined &&
+            elementECClassIds.has(change.ECClassId))
+        )
           hasElementChangedCache.add(change.ECInstanceId);
       }