From 8a31c9db880d28648505bf244d1c1ccfba010b00 Mon Sep 17 00:00:00 2001
From: Ashar Fuadi <fushar@gmail.com>
Date: Sat, 13 Jul 2024 21:27:29 +0700
Subject: [PATCH] Split Gender and Grade columns

---
 app/Controllers/Competition.php | 23 +++++++++++++++++++----
 1 file changed, 19 insertions(+), 4 deletions(-)

diff --git a/app/Controllers/Competition.php b/app/Controllers/Competition.php
index 43f0b8d..3c90315 100644
--- a/app/Controllers/Competition.php
+++ b/app/Controllers/Competition.php
@@ -165,8 +165,11 @@ public function results($id) {
 			'Nama',
 		);
 
-		if ($this->hasGradeAndGenderInfo($contestants)) {
+		if ($this->hasGenderInfo($contestants)) {
 			$heading[] = 'J.K.';
+		}
+
+		if ($this->hasGradeInfo($contestants)) {
 			$heading[] = 'Kls.';
 		}
 
@@ -199,8 +202,11 @@ public function results($id) {
 				['data' => linkPerson($c['PersonID'], $c['Name']), 'class' => $clazz],
 			);
 
-			if ($this->hasGradeAndGenderInfo($contestants)) {
+			if ($this->hasGenderInfo($contestants)) {
 				$row[] = ['data' => $c['Gender'], 'class' => 'col-gender ' . $clazz];
+			}
+
+			if ($this->hasGradeInfo($contestants)) {
 				$row[] = ['data' => $c['Grade'], 'class' => 'col-grade ' . $clazz];
 			}
 
@@ -374,9 +380,18 @@ private function getPastContestants($competition) {
 		return $result;
 	}
 
-	private function hasGradeAndGenderInfo($contestants) {
+	private function hasGenderInfo($contestants) {
+		foreach ($contestants as $c) {
+			if ($c['Gender']) {
+				return true;
+			}
+		}
+		return false;
+	}
+
+	private function hasGradeInfo($contestants) {
 		foreach ($contestants as $c) {
-			if ($c['Gender'] || $c['Grade']) {
+			if ($c['Grade']) {
 				return true;
 			}
 		}