Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Patterns find memory addr #49

Closed
XMDS opened this issue Mar 9, 2025 · 2 comments
Closed

Use Patterns find memory addr #49

XMDS opened this issue Mar 9, 2025 · 2 comments

Comments

@XMDS
Copy link

XMDS commented Mar 9, 2025

SKSE64 uses a real address and should use search bytecode technology to obtain the address.
This allows SKSE64 to support most game versions without the need to create branches.
Here is a lightweight and stable Patterns library:
https://github.com/ThirteenAG/Hooking.Patterns.git

@ianpatt
Copy link
Owner

ianpatt commented Mar 9, 2025

Not using pattern matching is an intentional choice due to how inaccurate and generally terrible pattern matching is. Every time Bethesda patches the game, I need to deal with plugins that use pattern matching that break silently and crash the game. The technology proves itself as useless on a regular basis.

@ianpatt ianpatt closed this as not planned Won't fix, can't repro, duplicate, stale Mar 9, 2025
@XMDS
Copy link
Author

XMDS commented Mar 9, 2025

I respect your choice. It depends on you. But personally, I think it's better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants