fix(extract): substrait function argument ordering

According to the spec, you cannot have the function option argument
specified after a "regular" argument.

Update ibis_substrait/compiler/translate.py

Co-authored-by: Phillip Cloud <417981+cpcloud@users.noreply.github.com>

Author: gforsyth

ibis_substrait/compiler/mapping.py

@@ -34,6 +34,6 @@
     v: getattr(ops, k) for k, v in IBIS_SUBSTRAIT_OP_MAPPING.items()
 }
 # override when reversing many-to-one mappings
-SUBSTRAIT_IBIS_OP_MAPPING["extract"] = lambda table, span: getattr(
+SUBSTRAIT_IBIS_OP_MAPPING["extract"] = lambda span, table: getattr(
     ops, f"Extract{span.capitalize()}"
 )(table)

ibis_substrait/compiler/translate.py

@@ -968,16 +968,18 @@ def _extractdatefield(
     compiler: SubstraitCompiler,
     **kwargs: Any,
 ) -> stalg.Expression:
+    # e.g. "ExtractYear" -> "YEAR"
+    span = type(op).__name__[len("Extract") :].upper()
+    args = (
+        translate(arg, compiler, **kwargs)
+        for arg in op.args
+        if isinstance(arg, ir.Expr)
+    )
+
     scalar_func = stalg.Expression.ScalarFunction(
         function_reference=compiler.function_id(expr),
         output_type=translate(expr.type()),
-        args=[
-            translate(arg, compiler, **kwargs)
-            for arg in op.args
-            if isinstance(arg, ir.Expr)
-        ],
     )
-    # e.g. "ExtractYear" -> "YEAR"
-    span = type(op).__name__.lstrip("Extract").upper()
     scalar_func.args.add(enum=stalg.Expression.Enum(specified=span))
+    scalar_func.args.extend(args)
     return stalg.Expression(scalar_function=scalar_func)