Skip to content

Commit 47d97ea

Browse files
cpcloudjcrist
authored andcommitted
feat(oracle): support group_concat operator
1 parent a63cee9 commit 47d97ea

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

ibis/backends/sql/compilers/oracle.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -446,3 +446,9 @@ def visit_StringConcat(self, op, *, arg):
446446

447447
def visit_ExtractIsoYear(self, op, *, arg):
448448
return self.cast(self.f.to_char(arg, "IYYY"), op.dtype)
449+
450+
def visit_GroupConcat(self, op, *, arg, where, sep):
451+
if where is not None:
452+
arg = self.if_(where, arg)
453+
454+
return self.f.listagg(arg, sep)

ibis/backends/tests/test_aggregation.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1234,11 +1234,6 @@ def test_date_quantile(alltypes):
12341234
],
12351235
)
12361236
@pytest.mark.notimpl(["datafusion", "polars"], raises=com.OperationNotDefinedError)
1237-
@pytest.mark.notyet(
1238-
["oracle"],
1239-
raises=OracleDatabaseError,
1240-
reason="ORA-00904: 'GROUP_CONCAT': invalid identifier",
1241-
)
12421237
@pytest.mark.notimpl(["exasol"], raises=ExaQueryError)
12431238
@pytest.mark.notyet(["flink"], raises=Py4JJavaError)
12441239
def test_group_concat(

0 commit comments

Comments
 (0)