Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce unit testing time by removing some test case time period scenario tests #576

Closed
dhblum opened this issue Sep 13, 2023 · 0 comments
Closed
Milestone

Comments

@dhblum
Copy link
Collaborator

dhblum commented Sep 13, 2023

The inclusion of larger and more complex test cases increases the time it takes to run simulations. In addition, for larger test cases, use of CS fmus is proving to take longer to run simulations. For example, the latest CI tests in #536 take ~7 hours to complete and it's possible the CI tests in #569 would take a day or more given reported computation times on that emulator.

A significant amount of CI time is running all iterations of all time period scenarios of each test case for their three-week duration (warmup week + two-week test period). For emulators with heating and cooling systems, that equates to 5 tests (peak/typical_heating/cooling and mix). For emulators without one or the other, there are two-day tests that are run to test on results for specific seasons not covered by a time period scenario (e.g. summer, winter).

My proposal here is to reduce the amount of simulations run for each test case as they may be overkill and unnecessarily adding to testing time. This could be done perhaps by either:

  1. Reducing which time period scenarios that are tested. For example, only run peak_heating and peak_cooling, or similar, instead of all.
  2. Only run the two-day seasonal tests for all emulators, which would significantly shorten things.

The down sides here are less test coverage on the test case models and not having the KPIs and results for every time period scenario for every test case tested with each CI run. Note that I'd still intend KPIs and results would still be tested for any time period scenarios or seasonal tests that are run.

I wanted to float this and see if there are thoughts for or against or alternative ideas.

@dhblum dhblum added this to the v0.6.0 milestone Sep 21, 2023
@dhblum dhblum closed this as completed in 2b4328c Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant