-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue617 refactor service with history 2 #652
base: master
Are you sure you want to change the base?
Conversation
Working (although incomplete) twoday example
Update API and add example controller
There is global attribution at the project root
Use redis messages to generate results as they are requested, instead of the very time consuming approach of computing them on every step
Remove some unwanted Alfalfa isms
The exceptions are the min/max test, plus julia and javascript tests
My setup is similar to @EttoreZ's and I'm dissapointed that I cannot reproduce @javiarrobas's issue. My test system is a M1 MacBook Pro with macOS version 15.0.1. This computer did not have Docker so I downloaded and installed the latest Docker Desktop for Apple Silicon. That gave me Docker Engine 27.2.0, build 3ab4256. All of the test cases provisioned fine in my case. |
@javiarrobas since I can't reproduce I'm trying to think of ways to help troubleshoot. One key thing is that the provision container uses a volume to bring the test case files into the container. I wonder if there is some stale data in there. Here's some possible debug steps.
|
Thanks @kbenne for the additional testing. In some ways, good there were no issues, however, I would like to figure out what's going on here before merging. @javiarrobas if you can, please see if Kyle's suggestions help? I would emphasize that the use of |
I finally could figure out what was going on. The suggestion of @kbenne turned out helpful for that. When running the provision container and inspecting the files I got: |
I think we can probably come up with a simple enhancement to the globbing mechanism that is used to find FMUs and make this more robust. |
Or yeah.. Like you said @javiarrobas, we could just explicitly enumerate them in a list. |
Huzzah! 🎉 Thank you @javiarrobas for continuing to try. One thing I'm curious about is still why it got stuck if there was a valid .fmu in that directory? Regarding the point of explicit list, we may think about if that list should be in any way accessible so anyone who wants to load in their own test case when running on their machine/setup can. But that goes back to my initial question, I wonder why it got stuck. |
That's because it was not a valid .fmu file but an empty folder called |
Ohh ok, I see! |
@javiarrobas @kbenne @EttoreZ I've addressed all Javier's comments (including a proposed readme convergence), Kyle's implemented updates from ADRENALIN, and Ettore's helped with updating some utility scripts to work with the new architecture. I think this PR is very very close to being ready to merge. Nothing more comes to my mind to be done at this point, except for a protection that was mentioned against what happened with Javier, but perhaps we save that for a specific issue on it's own as an enhancement? Can you all review/test a final time(s) and let me know any further comments or issues to be addressed? If you're ok with merging, please approve the github review. Note that I expect pending tests to pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I agree to address the safeguard mechanism for the issue I had in a separate issue.
This is for #617 and #671 and in place of #622. It does everything from #622, but merges the Service architecture in a way to include the nrel/boptest-service git history.