Skip to content

Commit 70a889d

Browse files
committed
Merge branch 'feature/#336-base-screen' into feature/#334-text-theme
2 parents f630894 + 6060e80 commit 70a889d

12 files changed

+34
-35
lines changed

lib/screen/debug/debug_platform_selector_screen.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import 'package:flutter_navigation_generator_annotations/flutter_navigation_gene
33
import 'package:flutter_template/di/injectable.dart';
44
import 'package:flutter_template/viewmodel/debug/debug_platform_selector_viewmodel.dart';
55
import 'package:flutter_template/widget/debug/selector_item.dart';
6-
import 'package:flutter_template/widget/general/simple_screen/base_screen.dart';
6+
import 'package:flutter_template/widget/general/base_screen/base_screen.dart';
77
import 'package:flutter_template/widget/provider/provider_widget.dart';
88

99
@flutterRoute

lib/screen/debug/debug_screen.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import 'package:flutter_template/viewmodel/global/global_viewmodel.dart';
77
import 'package:flutter_template/widget/debug/debug_row_item.dart';
88
import 'package:flutter_template/widget/debug/debug_row_title.dart';
99
import 'package:flutter_template/widget/debug/debug_switch_row_item.dart';
10-
import 'package:flutter_template/widget/general/simple_screen/base_screen.dart';
10+
import 'package:flutter_template/widget/general/base_screen/base_screen.dart';
1111
import 'package:flutter_template/widget/provider/provider_widget.dart';
1212
import 'package:provider/provider.dart';
1313

lib/screen/license/license_screen.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import 'package:flutter_navigation_generator_annotations/flutter_navigation_gene
33
import 'package:flutter_template/di/injectable.dart';
44
import 'package:flutter_template/styles/theme_data.dart';
55
import 'package:flutter_template/viewmodel/license/license_viewmodel.dart';
6-
import 'package:flutter_template/widget/general/simple_screen/base_screen.dart';
6+
import 'package:flutter_template/widget/general/base_screen/base_screen.dart';
77
import 'package:flutter_template/widget/provider/provider_widget.dart';
88

99
@flutterRoute

lib/screen/log_detail/log_detail_screen.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import 'package:flutter_navigation_generator_annotations/flutter_navigation_gene
33
import 'package:flutter_template/di/injectable.dart';
44
import 'package:flutter_template/styles/theme_data.dart';
55
import 'package:flutter_template/viewmodel/log_detail/log_detail_viewmodel.dart';
6-
import 'package:flutter_template/widget/general/simple_screen/base_screen.dart';
6+
import 'package:flutter_template/widget/general/base_screen/base_screen.dart';
77
import 'package:flutter_template/widget/general/styled/flutter_template_button.dart';
88
import 'package:flutter_template/widget/provider/provider_widget.dart';
99

lib/screen/login/login_screen.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import 'package:flutter_template/di/injectable.dart';
44
import 'package:flutter_template/styles/theme_data.dart';
55
import 'package:flutter_template/util/keys.dart';
66
import 'package:flutter_template/viewmodel/login/login_viewmodel.dart';
7-
import 'package:flutter_template/widget/general/simple_screen/base_screen.dart';
7+
import 'package:flutter_template/widget/general/base_screen/base_screen.dart';
88
import 'package:flutter_template/widget/general/styled/flutter_template_button.dart';
99
import 'package:flutter_template/widget/general/styled/flutter_template_input_field.dart';
1010
import 'package:flutter_template/widget/general/styled/flutter_template_progress_indicator.dart';

lib/screen/logs/logs_screen.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import 'package:flutter_template/di/injectable.dart';
44
import 'package:flutter_template/styles/theme_data.dart';
55
import 'package:flutter_template/util/extension/date_time_extension.dart';
66
import 'package:flutter_template/viewmodel/logs/logs_viewmodel.dart';
7-
import 'package:flutter_template/widget/general/simple_screen/base_screen.dart';
7+
import 'package:flutter_template/widget/general/base_screen/base_screen.dart';
88
import 'package:flutter_template/widget/general/styled/flutter_template_button.dart';
99
import 'package:flutter_template/widget/provider/provider_widget.dart';
1010
import 'package:icapps_architecture/icapps_architecture.dart';

lib/screen/permission/analytics_permission_screen.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import 'package:flutter_template/di/injectable.dart';
55
import 'package:flutter_template/styles/theme_assets.dart';
66
import 'package:flutter_template/styles/theme_data.dart';
77
import 'package:flutter_template/viewmodel/permission/analytics_permission_viewmodel.dart';
8-
import 'package:flutter_template/widget/general/simple_screen/base_screen.dart';
8+
import 'package:flutter_template/widget/general/base_screen/base_screen.dart';
99
import 'package:flutter_template/widget/general/styled/flutter_template_button.dart';
1010
import 'package:flutter_template/widget/provider/provider_widget.dart';
1111

lib/screen/todo/todo_list/todo_list_screen.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import 'package:flutter_template/styles/theme_data.dart';
66
import 'package:flutter_template/util/keys.dart';
77
import 'package:flutter_template/viewmodel/todo/todo_list/todo_list_viewmodel.dart';
88
import 'package:flutter_template/widget/general/action/action_item.dart';
9-
import 'package:flutter_template/widget/general/simple_screen/base_screen.dart';
9+
import 'package:flutter_template/widget/general/base_screen/base_screen.dart';
1010
import 'package:flutter_template/widget/general/styled/flutter_template_progress_indicator.dart';
1111
import 'package:flutter_template/widget/provider/provider_widget.dart';
1212
import 'package:flutter_template/widget/todo/todo_row_item.dart';

lib/widget/general/simple_screen/base_screen.dart renamed to lib/widget/general/base_screen/base_screen.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import 'package:flutter/foundation.dart';
22
import 'package:flutter/material.dart';
3-
import 'package:flutter_template/widget/general/simple_screen/base_screen_content.dart';
4-
import 'package:flutter_template/widget/general/simple_screen/base_screen_header.dart';
3+
import 'package:flutter_template/widget/general/base_screen/base_screen_content.dart';
4+
import 'package:flutter_template/widget/general/base_screen/base_screen_header.dart';
55
import 'package:flutter_template/widget/general/status_bar.dart';
66
import 'package:flutter_template/widget/general/styled/flutter_template_progress_indicator.dart';
77
import 'package:flutter_template/widget/provider/data_provider_widget.dart';

lib/widget/general/simple_screen/base_screen_content.dart renamed to lib/widget/general/base_screen/base_screen_content.dart

Lines changed: 22 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -24,43 +24,42 @@ class BaseScreenContent extends StatelessWidget {
2424

2525
@override
2626
Widget build(BuildContext context) {
27-
final Widget content;
27+
if (itemBuilder != null) {
28+
return ListView.builder(
29+
padding: padding,
30+
itemBuilder: itemBuilder!,
31+
itemCount: itemCount,
32+
reverse: reversed,
33+
);
34+
}
2835

2936
if (children.isNotEmpty) {
3037
if (useSlivers) {
31-
content = CustomScrollView(
38+
return CustomScrollView(
3239
slivers: children,
3340
reverse: reversed,
3441
);
35-
} else if (isScrollable) {
36-
content = ListView(
42+
}
43+
if (isScrollable) {
44+
return ListView(
3745
padding: padding,
3846
reverse: reversed,
3947
children: children,
4048
);
41-
} else {
42-
content = Padding(
43-
padding: padding,
44-
child: Column(
45-
verticalDirection: reversed ? VerticalDirection.up : VerticalDirection.down,
46-
children: children,
47-
),
48-
);
4949
}
50-
} else if (itemBuilder != null) {
51-
content = ListView.builder(
50+
51+
return Padding(
5252
padding: padding,
53-
itemBuilder: itemBuilder!,
54-
itemCount: itemCount,
55-
reverse: reversed,
56-
);
57-
} else {
58-
content = Padding(
59-
padding: padding,
60-
child: child,
53+
child: Column(
54+
verticalDirection: reversed ? VerticalDirection.up : VerticalDirection.down,
55+
children: children,
56+
),
6157
);
6258
}
6359

64-
return content;
60+
return Padding(
61+
padding: padding,
62+
child: child,
63+
);
6564
}
6665
}

lib/widget/general/simple_screen/base_screen_header.dart renamed to lib/widget/general/base_screen/base_screen_header.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import 'package:flutter/material.dart';
22
import 'package:flutter_template/styles/theme_data.dart';
33
import 'package:flutter_template/util/platform/platform_util.dart';
4-
import 'package:flutter_template/widget/general/simple_screen/base_screen_header_safe_area.dart';
4+
import 'package:flutter_template/widget/general/base_screen/base_screen_header_safe_area.dart';
55
import 'package:flutter_template/widget/general/styled/flutter_template_back_button.dart';
66
import 'package:flutter_template/widget/provider/data_provider_widget.dart';
77

@@ -68,7 +68,7 @@ class BaseScreenHeader extends StatelessWidget {
6868
actions: trailingItems,
6969
child: titleWidget,
7070
),
71-
]
71+
],
7272
],
7373
),
7474
),

0 commit comments

Comments
 (0)