-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please add multi modal widget #132
Comments
this sounds like a decent change! |
@genusistimelord please review PR #169. I think it is a better solution to support multiple overlays: it removes the Actually I think there is even a simpler solution: by removing the If you do not like the two above implementations, then a new |
yeah just fix the clippy issue as it should be good to merge. |
Oh and add an example showing multiple modals in usage would be nice too. |
Hi @genusistimelord I saw that you already merged PR #169 and fixed the clippy issue yourself. Sorry I did not answer before but yes I am adding a multiple modals example, just hold on and I am going to PR it. Before that I am also going to fix the modal's comments and documentation. |
ok thats fine. PR whenever your ready. I will close this since the last one fixed the problem. |
The current
modal
widget is restricted to only two possible states: visible and not-visible. This makes quite tricky to implement modals with multiple possible overlays.It would be very useful to have a
multi_modal
widget, or otherwise to extend the currentmodal
widget. This widget could accept for instance ashow_modal: Option<usize>
parameter, and then an array of overlay contents. In case ofshow_modal = None
no overlay would be shown, and in case ofshow_modal = Some(i)
thecontent[i]
overlay would be shown.The text was updated successfully, but these errors were encountered: