Skip to content
This repository has been archived by the owner on Feb 15, 2024. It is now read-only.

UI is not updating/working with some web extensions turned on #5

Open
orsenkucher opened this issue Sep 28, 2020 · 3 comments
Open

Comments

@orsenkucher
Copy link

Something within Dark Reader chrome extension is blocking iced from updating the UI.
As you can see, two radio buttons are selected and slider value was not updated, despite slider itself being moved.
Click on button does nothing as well
image
Demo is perfectly fine when extension is turned off and page reloaded. Also every other page on internet behaves normally with extension working. So I assume iced XOR dark reader are yielding this.

@orsenkucher
Copy link
Author

might be a consequence of some broader problem somehow utilized by extension 🤷‍♂️

@Kaiden42
Copy link

Kaiden42 commented Oct 3, 2020

I can confirm this. DarkReader is adding an own style element after each style element found in the body. It seems that Dodrio isn't aware of a change from outside, wich breaks the VDOM.

dodrio/change-list.js:90 Uncaught TypeError: Cannot read property 'firstChild' of null
    at Array.pushFirstChild (dodrio/change-list.js:90)
    at ChangeList.applyChangeRange (dodrio/change-list.js:231)
    at ChangeList.applyChanges (dodrio/change-list.js:220)
    at imports.wbg.__wbg_applyChanges_80aff4692bcb5634 (tour.js:281)
    at /tour/tour_bg.wasm:wasm-function[125]:0x63f2d
    at /tour/tour_bg.wasm:wasm-function[305]:0x8715e
    at /tour/tour_bg.wasm:wasm-function[638]:0x96d16
    at __wbg_elem_binding2 (tour.js:27)
    at real (tour.js:444)

If I add an additional style element by myself to iced.rs like this:

...
<div style="width: 100%; height: 100%">
    <style>...</style>
    <style></style><!-- the style I've added -->
    <div class="c" ...>
        ...
    </div>
</div>
...

... I get a similar error:

dodrio/change-list.js:97 Uncaught TypeError: Cannot read property 'nextSibling' of null
    at Array.popPushNextSibling (dodrio/change-list.js:97)
    at ChangeList.applyChangeRange (dodrio/change-list.js:231)
    at ChangeList.applyChanges (dodrio/change-list.js:220)
    at imports.wbg.__wbg_applyChanges_80aff4692bcb5634 (tour.js:281)
    at /tour/tour_bg.wasm:wasm-function[125]:0x63f2d
    at /tour/tour_bg.wasm:wasm-function[305]:0x8715e
    at /tour/tour_bg.wasm:wasm-function[638]:0x96d16
    at __wbg_elem_binding2 (tour.js:27)
    at real (tour.js:444)

There is already an open issue at the dodrio repository.

@Absolucy
Copy link

Absolucy commented Jan 5, 2021

i feel like dodrio is abandoned/unmaintained at this point, so this isn't going to be fixed anytime soon.

@hecrj hecrj transferred this issue from iced-rs/iced Jan 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants