Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/fix grpc when run soccer #42

Merged
merged 3 commits into from
May 6, 2024
Merged

Conversation

marfanr
Copy link
Contributor

@marfanr marfanr commented May 6, 2024

Jira Link:

Description

Remove 'grpc' from the exported CMake to fix conflicts (using both statically and dynamically linked libraries) when running Soccer because the exported 'grpc' is also unused in Soccer."

Type of Change

  • Bugfix
  • Enhancement
  • New feature
  • Breaking change (fix or feature that would cause the existing functionality to not work as expected)

How Has This Been Tested?

  • New unit tests added.
  • Manual tested.

Checklist:

  • Using Branch Name Convention
    • feature/JIRA-ID-SHORT-DESCRIPTION if has a JIRA ticket
    • enhancement/SHORT-DESCRIPTION if has/has no JIRA ticket and contain enhancement
    • hotfix/SHORT-DESCRIPTION if the change doesn't need to be tested (urgent)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have made the documentation for the corresponding changes.

@marfanr marfanr merged commit be6f267 into master May 6, 2024
1 check failed
@marfanr marfanr deleted the hotfix/fix-grpc-when-run-soccer branch May 6, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants