Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add Brake Action Service #48

Merged
merged 2 commits into from
Jul 13, 2024
Merged

[Feature] Add Brake Action Service #48

merged 2 commits into from
Jul 13, 2024

Conversation

mbsaloka
Copy link
Contributor

Jira Link:

Description

Grpc service for brake action

Type of Change

  • Bugfix
  • Enhancement
  • New feature
  • Breaking change (fix or feature that would cause the existing functionality to not work as expected)

How Has This Been Tested?

  • New unit tests added.
  • Manual tested.

Checklist:

  • Using Branch Name Convention
    • feature/JIRA-ID-SHORT-DESCRIPTION if has a JIRA ticket
    • enhancement/SHORT-DESCRIPTION if has/has no JIRA ticket and contain enhancement
    • hotfix/SHORT-DESCRIPTION if the change doesn't need to be tested (urgent)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have made the documentation for the corresponding changes.

@mbsaloka mbsaloka merged commit 7901cbb into master Jul 13, 2024
1 check failed
@mbsaloka mbsaloka deleted the feature/brake-action-service branch July 13, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@threeal threeal threeal left review comments

@borednuna borednuna borednuna approved these changes

@FaaizHaikal FaaizHaikal FaaizHaikal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mbsaloka @threeal @borednuna @FaaizHaikal