Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sprint 22 / PD-401] [Enhancement] Update Github Workflows #34

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

marfanr
Copy link

@marfanr marfanr commented Feb 26, 2024

Jira Link:

https://ichiro-its.atlassian.net/jira/software/c/projects/PD/boards/4?selectedIssue=PD-401

Description

update github workflow using ros2-ws-action

Type of Change

  • Bugfix
  • Enhancement
  • New feature
  • Breaking change (fix or feature that would cause the existing functionality to not work as expected)

How Has This Been Tested?

  • New unit tests added.
  • Manual tested.

Checklist:

  • Using Branch Name Convention
    • feature/JIRA-ID-SHORT-DESCRIPTION if has a JIRA ticket
    • enhancement/SHORT-DESCRIPTION if has/has no JIRA ticket and contain enhancement
    • hotfix/SHORT-DESCRIPTION if the change doesn't need to be tested (urgent)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have made the documentation for the corresponding changes.

.github/workflows/build-ros2-ws-action.yml Outdated Show resolved Hide resolved
.github/workflows/build-ros2-ws-action.yml Outdated Show resolved Hide resolved
.github/workflows/build-ros2-ws-action.yml Outdated Show resolved Hide resolved
Copy link
Member

@threeal threeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good in this PR, but it would be better if you could also remove the other unused workflow.

Regarding the failed workflow run, it seems that it was caused by an unused include in this line:

#include <kansei_interfaces/msg/fallen.hpp>

Removing that should likely fix the build issue. However, you can fix this in another PR though.

@marfanr marfanr force-pushed the hotfix/fix-github-workflows branch from ef914d6 to f33c7e8 Compare August 27, 2024 10:18
Copy link
Member

@threeal threeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is failing in Keisan, try to fix this first. The other tests from other packages are also failing.

.github/workflows/dispatch-discord-pr-bot.yml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants