check if primary claimed as dependent

Author: jacobkagon

lib/aca_entities/atp/functions/build_application.rb

@@ -323,6 +323,7 @@ def applicant_hash
 
           tribe_name = @tribal_augmentation[:person_tribe_name]
           tribe_codes = AcaEntities::Atp::Functions::TribeCodesBuilder.new.call(tribe_name) if tribe_indicator
+          claimed_as_dependent = tax_returns_hash[:tax_dependents].nil? ? nil : tax_returns_hash[:tax_dependents].include?(@applicant_identifier)
           {
             is_primary_applicant: @applicant_identifier == @primary_applicant_identifier,
             name: name_hash,
@@ -364,8 +365,8 @@ def applicant_hash
             tax_filer_kind: @tax_return.nil? ? nil : TAX_FILER_KIND[@tax_return[:status_code]],
             is_filing_as_head_of_household: tax_returns_hash[:is_head_of_household] ? true : false,
             is_joint_tax_filing: tax_returns_hash[:joint_tax_filing_status],
-            is_claimed_as_tax_dependent: tax_returns_hash[:tax_dependents].nil? ? nil : tax_returns_hash[:tax_dependents].include?(@applicant_identifier), # default value
-            claimed_as_tax_dependent_by: @primary_applicant_identifier == @applicant_identifier ? nil : @primary_applicant_identifier,
+            is_claimed_as_tax_dependent: claimed_as_dependent,
+            claimed_as_tax_dependent_by: claimed_as_dependent ? @primary_applicant_identifier : nil,
             student: other_questions[:student],
             is_refugee: nil, # default value
             is_trafficking_victim: nil, # default value

spec/aca_entities/atp/functions/build_application_spec.rb

@@ -186,8 +186,8 @@
       expect(@result[:applicants][0][:claimed_as_tax_dependent_by]).to be nil
     end
 
-    it "populates is_claimed_as_tax_dependent_by for non-primary applicants" do
-      expect(@result[:applicants][1][:claimed_as_tax_dependent_by]).to eql(@result[:applicants][0][:person_hbx_id])
+    it "does not populate is_claimed_as_tax_dependent for primary applicants" do
+      expect(@result[:applicants][1][:claimed_as_tax_dependent_by]).to be nil
     end
   end
 end