Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Idea/v9] Optional core-js polyfill and change javascript utility from lodash to just #407

Open
idiotWu opened this issue Nov 1, 2021 Discussed in #406 · 0 comments
Open

[Idea/v9] Optional core-js polyfill and change javascript utility from lodash to just #407

idiotWu opened this issue Nov 1, 2021 Discussed in #406 · 0 comments
Assignees
@idiotWu
Labels
accepted Feature requests that have been accepted. idea
Milestone
v9

Comments

@idiotWu
Copy link
Owner

idiotWu commented Nov 1, 2021

Discussed in #406

Originally posted by sadeghbarati November 1, 2021
https://bundlephobia.com/package/smooth-scrollbar@8.7.0

optional core-js for the next release will be the best option because ppl may already have core-js polyfills on their project (duplicate polyfills code)
or even don't wanted to polyfill older browsers

optional: use just utility instead of lodash

https://github.com/angus-c/just
https://github.com/puruvj/all-of-just
lodash vs just: angus-c/just#4
@idiotWu idiotWu added idea accepted Feature requests that have been accepted. labels Nov 1, 2021
@idiotWu idiotWu added this to the v9 milestone Nov 1, 2021
@idiotWu idiotWu self-assigned this Nov 1, 2021
@idiotWu idiotWu moved this to IDEA in smooth-scrollbar@v9 Nov 16, 2022
sadeghbarati added a commit that referenced this issue Apr 9, 2023
@sadeghbarati
refactor!: move scroll functionality into @smooth-scrollbar/core
e3e6d66 
- remove dynamic style #235
- remove core-js polyfills #407
- expose only ScrollbarOptions type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@idiotWu idiotWu

Labels
accepted Feature requests that have been accepted. idea
Projects
smooth-scrollbar@v9
Status: IDEA
Milestone
v9
Development

No branches or pull requests
1 participant
@idiotWu