Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency-specific configuration should not be part of Obelisk definitions #45

Open
wkerckho opened this issue Jul 15, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@wkerckho
Copy link
Contributor

The class OblxConfig should not contain dependency-specific configuration properties, these should be encapsulated in the plug-ins that provide the implementation for interfacing with a dependency.

This also implies that the system will not know upfront, which config properties will be required for configuring the concrete implementations (via plug-ins) for the DataStore, MetaStore, etc. To support this, changes will also be needed to the common helm chart (affecting the way the configuration is loaded into environment variables).

@wkerckho wkerckho added the enhancement New feature or request label Jul 15, 2022
@github-actions
Copy link
Contributor

The issue had no activity for 30 days, mark with Stale label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants