Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Bao and Staudt to Review #279

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

PhilippSchmelter
Copy link
Contributor

This pull request includes updates to the list of reviewers in the .github/dependabot.yml file and an update to the CHANGELOG.md file to reflect these changes.

Updates to reviewer list:

  • .github/dependabot.yml: Replaced reviewer sensarmad with jo-bao and added staudtMarius to the list of reviewers.

Documentation update:

  • CHANGELOG.md: Added an entry under the "Unreleased" section to document the addition of Bao and Staudt to the list of reviewers.

@PhilippSchmelter PhilippSchmelter self-assigned this Dec 17, 2024
@PhilippSchmelter PhilippSchmelter linked an issue Dec 17, 2024 that may be closed by this pull request
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.42%. Comparing base (510235d) to head (30701b6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #279   +/-   ##
=======================================
  Coverage   63.42%   63.42%           
=======================================
  Files          70       70           
  Lines        2097     2097           
  Branches       51       51           
=======================================
  Hits         1330     1330           
  Misses        767      767           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this. Just one question from my side

uuidMap should contain key "1-LV-rural1--2-no_sw"
uuidMap("1-LV-urban6--0-sw") should fullyMatch regex uuidPattern
uuidMap("1-LV-rural1--2-no_sw") should fullyMatch regex uuidPattern
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to remove these?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependabot.yml
2 participants