-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Bao and Staudt to Review #279
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #279 +/- ##
=======================================
Coverage 63.42% 63.42%
=======================================
Files 70 70
Lines 2097 2097
Branches 51 51
=======================================
Hits 1330 1330
Misses 767 767 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this. Just one question from my side
uuidMap should contain key "1-LV-rural1--2-no_sw" | ||
uuidMap("1-LV-urban6--0-sw") should fullyMatch regex uuidPattern | ||
uuidMap("1-LV-rural1--2-no_sw") should fullyMatch regex uuidPattern |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to remove these?
This pull request includes updates to the list of reviewers in the
.github/dependabot.yml
file and an update to theCHANGELOG.md
file to reflect these changes.Updates to reviewer list:
.github/dependabot.yml
: Replaced reviewersensarmad
withjo-bao
and addedstaudtMarius
to the list of reviewers.Documentation update:
CHANGELOG.md
: Added an entry under the "Unreleased" section to document the addition of Bao and Staudt to the list of reviewers.