Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix determination of qDotIntoGrid in HpModel.calcState() in case heatStorage should feed the thermal grid #1165

Open
danielfeismann opened this issue Feb 11, 2025 · 0 comments · May be fixed by #1166
Open

Fix determination of qDotIntoGrid in HpModel.calcState() in case heatStorage should feed the thermal grid #1165

danielfeismann opened this issue Feb 11, 2025 · 0 comments · May be fixed by #1166
Assignees
@danielfeismann
Labels
bug Something isn't working

Comments

@danielfeismann
Copy link
Member

danielfeismann commented Feb 11, 2025 •
edited
Loading

https://github.com/ie3-institute/simona/blob/dev/src/main/scala/edu/ie3/simona/model/participant/HpModel.scala#L236

lastStateStorageQDot == zeroKW && (demandWrapper.houseDemand.hasRequiredDemand || demandWrapper.heatStorageDemand.hasRequiredDemand)

The second part of the OR condition does not really make sense, instead we should check if the storage isn't empty.

currentEnergyOfThermalStorage > zeroKWh && demandWrapper.houseDemand.hasAdditionalDemand
@danielfeismann danielfeismann added the bug Something isn't working label Feb 11, 2025
@danielfeismann danielfeismann self-assigned this Feb 11, 2025
@danielfeismann danielfeismann changed the title Fix determination of qDotIntoGrid in HpModell.calcState() in case heatStorage should feed the thermal grid Fix determination of qDotIntoGrid in HpModel.calcState() in case heatStorage should feed the thermal grid Feb 11, 2025
@danielfeismann danielfeismann linked a pull request Feb 11, 2025 that will close this issue
Open
danielfeismann added a commit that referenced this issue Feb 17, 2025
@danielfeismann
Merge branch 'dev' into df/#1165-determination-of-qDotIntoGrid
18bb4e7 
# Conflicts:
#	CHANGELOG.md
danielfeismann added a commit that referenced this issue Feb 17, 2025
@danielfeismann
Merge branch 'dev' into df/#1165-determination-of-qDotIntoGrid
89a6fb8
danielfeismann added a commit that referenced this issue Feb 17, 2025
@danielfeismann
Merge branch 'dev' into df/#1165-determination-of-qDotIntoGrid
358cf79
danielfeismann added a commit that referenced this issue Feb 17, 2025
@danielfeismann
Merge remote-tracking branch 'origin/df/#1165-determination-of-qDotIn…
744347c 
…toGrid' into df/#1165-determination-of-qDotIntoGrid
danielfeismann added a commit that referenced this issue Feb 18, 2025
@danielfeismann
Merge branch 'dev' into df/#1165-determination-of-qDotIntoGrid
a5b07cb 
# Conflicts:
#	CHANGELOG.md
danielfeismann added a commit that referenced this issue Feb 18, 2025
@danielfeismann
Merge branch 'dev' into df/#1165-determination-of-qDotIntoGrid
e103d40 
# Conflicts:
#	CHANGELOG.md
danielfeismann added a commit that referenced this issue Feb 19, 2025
@danielfeismann
Merge branch 'dev' into df/#1165-determination-of-qDotIntoGrid
01bd1e0 
# Conflicts:
#	CHANGELOG.md
danielfeismann added a commit that referenced this issue Feb 19, 2025
@danielfeismann
Merge branch 'dev' into df/#1165-determination-of-qDotIntoGrid
635f770 
# Conflicts:
#	CHANGELOG.md
danielfeismann added a commit that referenced this issue Feb 19, 2025
@danielfeismann
Merge remote-tracking branch 'origin/df/#1165-determination-of-qDotIn…
2f59bf0 
…toGrid' into df/#1165-determination-of-qDotIntoGrid

# Conflicts:
#	CHANGELOG.md
danielfeismann added a commit that referenced this issue Feb 19, 2025
@danielfeismann
Merge branch 'dev' into df/#1165-determination-of-qDotIntoGrid
24f1cb3 
# Conflicts:
#	CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielfeismann danielfeismann

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix determination of qDotIntoGrid in HpModel.calcState() in case heat… ie3-institute/simona
1 participant
@danielfeismann