Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base PvModel calculations on irradiance (power per area) instead of irradiation (energy per area) #1212

Open
sebastian-peter opened this issue Feb 20, 2025 · 0 comments · May be fixed by #1213
Open

Base PvModel calculations on irradiance (power per area) instead of irradiation (energy per area) #1212

sebastian-peter opened this issue Feb 20, 2025 · 0 comments · May be fixed by #1213
Assignees
@sebastian-peter
Labels
bug Something isn't working enhancement New feature or request

Comments

@sebastian-peter
Copy link
Member

sebastian-peter commented Feb 20, 2025 •
edited
Loading

Since we divide by yieldSTC for the given time frame in the end, it does not make a difference in the end.

Furthermore, the extraterrestrial irradiance G_sc was a radiation before, which is not correct.

Replaces efforts on part of #1208
@sebastian-peter sebastian-peter added bug Something isn't working enhancement New feature or request labels Feb 20, 2025
@sebastian-peter sebastian-peter self-assigned this Feb 20, 2025
This was referenced Feb 20, 2025
Closed
Closed
Open
sebastian-peter added a commit that referenced this issue Feb 21, 2025
@sebastian-peter
Merge branch 'sp/#1212-PvModel-irradiance' into sp/#1149-new-PvModel
14578f8 
# Conflicts:
#	src/main/scala/edu/ie3/simona/agent/participant/pv/PvAgentFundamentals.scala
#	src/main/scala/edu/ie3/simona/model/participant/PvModel.scala
#	src/test/scala/edu/ie3/simona/model/participant2/PvModelSpec.scala
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastian-peter sebastian-peter

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Basing PvModel on irradiance, not irradiation ie3-institute/simona
1 participant
@sebastian-peter