Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple WebVTT comment blocks #394

Open
mkver opened this issue Jun 20, 2020 · 0 comments
Open

Multiple WebVTT comment blocks #394

mkver opened this issue Jun 20, 2020 · 0 comments
Labels
clarifications codec mapping spec_codecs Codec Matroska spec document target

Comments

@mkver
Copy link
Contributor

mkver commented Jun 20, 2020

The WebVTT codec mapping currently has this to say about WebVTT comments:

"The third and all following lines contain all WebVTT Comment Blocks that precede the current WebVTT Cue Block. These may be absent."

This does not say how multiple comment blocks are to be stored. mkvmerge separates them by a single \n, but this has the disadvantage that it doesn't allow to distinguish between different comment blocks and a single comment block that just happens to contain a NOTE in the middle after a newline. (Indeed, two comment blocks get merged when doing a mkvmerge->mkvextract roundtrip.) I therefore propose to use two line feed characters to distinguish different comment blocks.

Furthermore, mkvmerge strips comment blocks of their terminating WebVTT line terminator; this is currently against the spec, but I don't see a reason why this shouldn't be allowed. It is similar to not including the terminating line terminator of a WebVTT cue block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarifications codec mapping spec_codecs Codec Matroska spec document target
Projects
None yet
Development

No branches or pull requests

2 participants