Skip to content

Commit eefc012

Browse files
authored
Merge pull request #138 from ietf-wg-jose/presentation_jwk-consistency
Correct `pjwk` to `presentation_jwk`
2 parents a0a744e + a50e259 commit eefc012

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

draft-ietf-jose-json-proof-algorithms.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ Prior to the issuer creating a new JWP, it must have presentation binding inform
273273

274274
The presentation key used by the holder must be transferred to the issuer and verified, likely through a challenge and self-signing mechanism. If the holder requires unlinkability, it must also generate a new key that is verified and bound to each new JWP.
275275

276-
How these holder presentation keys are transferred and verified is out of scope of this specification. Protocols such as OpenID Connect can be used to accomplish this. What is required by this definition is that the holder's presentation key MUST be included in the issuer's protected header using the `pjwk` parameter with a JWK as the value.
276+
How these holder presentation keys are transferred and verified is out of scope of this specification. Protocols such as OpenID Connect can be used to accomplish this. What is required by this definition is that the holder's presentation key MUST be included in the issuer's protected header using the `presentation_jwk` parameter with a JWK as the value.
277277

278278
### Issuer Setup
279279

@@ -283,7 +283,7 @@ The Shared Secret is used by both the issuer and holder as the MAC method's key
283283

284284
### Issuer Protected Header {#issuer-protected-header}
285285

286-
The holder's presentation key JWK MUST be included in the issuer protected header using the `pjwk` parameter. The issuer MUST validate that the holder has possession of this key through a trusted mechanism such as verifying the signature of a unique nonce value from the holder.
286+
The holder's presentation key JWK MUST be included in the issuer protected header using the `presentation_jwk` parameter. The issuer MUST validate that the holder has possession of this key through a trusted mechanism such as verifying the signature of a unique nonce value from the holder.
287287

288288
### Combined MAC Representation
289289

@@ -317,7 +317,7 @@ See the JWS [Presentation Protected Header](#presentation-protected-header) sect
317317

318318
> Editor's Note: The current definition here is incomplete, the holder's signature needs to also incorporate the presented proof.
319319
320-
The first value in the presentation proof is the presentation signature. This is a signature over the presentation protected header, using the key specified by the `pjwk` parameter in the issuer protected header.
320+
The first value in the presentation proof is the presentation signature. This is a signature over the presentation protected header, using the key specified by the `presentation_jwk` parameter in the issuer protected header.
321321

322322
The second value is the issuer signature over the Combined MAC Representation provided with the issued form.
323323

@@ -802,6 +802,7 @@ The BBS examples were generated using the library at https://github.com/mattrglo
802802

803803
* Update reference to new repository home
804804
* Fixed #77: Removed vestigial use of `presentation_header`.
805+
* Correct `pjwk` to `presentation_jwk`
805806

806807
-05
807808

fixtures/mac-h256-fixtures.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ const holderPrivateKey = crypto.createPrivateKey({
3535
/// Create Issued JWP
3636

3737
// Modify the issuer protected header by adding the Holder's public key
38-
issuerProtectedHeaderJSON.pjwk = holderPublicKeyJSON;
38+
issuerProtectedHeaderJSON.presentation_jwk = holderPublicKeyJSON;
3939

4040
// encode/sign the issuer protected header w/ the stable key
4141
const finalIssuerProtectedHeader = JSON.stringify(issuerProtectedHeaderJSON);

0 commit comments

Comments
 (0)