Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Add JSDoc to types.ts #103

Open
1 of 3 tasks
igeligel opened this issue Oct 2, 2021 · 0 comments · May be fixed by #118
Open
1 of 3 tasks

Documentation: Add JSDoc to types.ts #103

igeligel opened this issue Oct 2, 2021 · 0 comments · May be fixed by #118
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest Hacktoberfest is a yearly developer festival where the participation in Open Source is appreciated help wanted Extra attention is needed trivial

Comments

@igeligel
Copy link
Owner

igeligel commented Oct 2, 2021

What should be changed?

  • An example is missing
  • Existing documentation needs to be extended
  • Something else, state below: JSDoc documentation is missing.

Description

For better usage of our props we can document them a bit more. This issue is quite easy and just involves documentation but also some understanding of how our components work.

A pull request for this issue should just add JSDoc comments for the src\types.ts file.

To explain from my own words what the things are used for:

  • IInOption: an option that will be shown on the left side of the selector in the component
  • IInOption.name: The name/label to show the option for. Could be "English", "German" or similar in the case of Google Translate
  • IInOption.active: Shows if the current option is active
  • IInOption.key: the key, mostly used because of: https://reactjs.org/docs/lists-and-keys.html
  • InOptions: An array of IInOption
  • IOutOption: The same as IInOption. An option that will be shown on the left side of the selector in the component. You can mention that another parameter was added to the interface.
  • IOutOption.activeClicked: Is a bit different than active because it shows a different color.
  • OutOptions: An array of IOutOption

Please rephrase these sentences so they makes sense. Resources that helped me to understand JSDoc comments:

Files involved

  • src\types.ts
@igeligel igeligel added documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest Hacktoberfest is a yearly developer festival where the participation in Open Source is appreciated help wanted Extra attention is needed trivial labels Oct 2, 2021
@zorfling zorfling linked a pull request Oct 28, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest Hacktoberfest is a yearly developer festival where the participation in Open Source is appreciated help wanted Extra attention is needed trivial
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant