You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With Igloo 4.0.0, we step into a jgtiflow issue. In basic-application-{core-webapp}/pom.xml, we use ${igloo.version} for igloo dependencies. It allow us to manage igloo and basic-application together, and when we create a new project from basic-application, we just add a <igloo.version>...</igloo.version> property in project's root pom to target the right Igloo version.
When jgitflow encounter an internal dependency (like igloo-component-spring), it detects that it is handled by a property. If there is no properties node in current pom.xml, it then ignores this artifact silently (this is the previous behavior, when we have no property definition in both core/webapp). But if there is any properties node, jgitflow throws an error if the version property is not in this node.
For 4.0.0, we rework basic-application-{core,webapp}/pom.xml so that it does not contain properties node.
We must find a way to use correctly properties node in basic-application project.
It is not an issue for a igloo-based project as jgtiflow ignore non-internal dependencies.
With Igloo 4.0.0, we step into a jgtiflow issue. In
basic-application-{core-webapp}/pom.xml
, we use${igloo.version}
for igloo dependencies. It allow us to manage igloo and basic-application together, and when we create a new project from basic-application, we just add a<igloo.version>...</igloo.version>
property in project's root pom to target the right Igloo version.When jgitflow encounter an internal dependency (like
igloo-component-spring
), it detects that it is handled by a property. If there is noproperties
node in current pom.xml, it then ignores this artifact silently (this is the previous behavior, when we have no property definition in both core/webapp). But if there is anyproperties
node, jgitflow throws an error if the version property is not in this node.For 4.0.0, we rework
basic-application-{core,webapp}/pom.xml
so that it does not containproperties
node.We must find a way to use correctly properties node in basic-application project.
It is not an issue for a igloo-based project as jgtiflow ignore non-internal dependencies.
Problem in jgtitflow is here : https://bitbucket.org/atlassian/jgit-flow/src/6a57ef1ec9c490b4633d46640df637df16774a62/jgitflow-maven-plugin/src/main/java/com/atlassian/maven/plugins/jgitflow/rewrite/ArtifactReleaseVersionChange.java#lines-232 ; if properties is null, there is no exception. If properties is not null, then version property must be resolvable else it throws an error.
The text was updated successfully, but these errors were encountered: