Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix basic-application + jgtiflow configuration #61

Open
lalmeras opened this issue May 16, 2022 · 0 comments
Open

Fix basic-application + jgtiflow configuration #61

lalmeras opened this issue May 16, 2022 · 0 comments

Comments

@lalmeras
Copy link
Member

With Igloo 4.0.0, we step into a jgtiflow issue. In basic-application-{core-webapp}/pom.xml, we use ${igloo.version} for igloo dependencies. It allow us to manage igloo and basic-application together, and when we create a new project from basic-application, we just add a <igloo.version>...</igloo.version> property in project's root pom to target the right Igloo version.

When jgitflow encounter an internal dependency (like igloo-component-spring), it detects that it is handled by a property. If there is no properties node in current pom.xml, it then ignores this artifact silently (this is the previous behavior, when we have no property definition in both core/webapp). But if there is any properties node, jgitflow throws an error if the version property is not in this node.

For 4.0.0, we rework basic-application-{core,webapp}/pom.xml so that it does not contain properties node.

We must find a way to use correctly properties node in basic-application project.

It is not an issue for a igloo-based project as jgtiflow ignore non-internal dependencies.

Problem in jgtitflow is here : https://bitbucket.org/atlassian/jgit-flow/src/6a57ef1ec9c490b4633d46640df637df16774a62/jgitflow-maven-plugin/src/main/java/com/atlassian/maven/plugins/jgitflow/rewrite/ArtifactReleaseVersionChange.java#lines-232 ; if properties is null, there is no exception. If properties is not null, then version property must be resolvable else it throws an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant