Add willremovecolumn event to enable discarding Popover instances on multi-locus panel removal

Author: turner

js/browser.js

@@ -56,6 +56,7 @@ import MultiTrackSelectButton from "./ui/multiTrackSelectButton.js"
 import MenuUtils from "./ui/menuUtils.js"
 import Genome from "./genome/genome.js"
 import {setDefaults} from "./igv-create.js"
+import { trackViewportPopoverList } from './trackViewport.js'
 
 // css - $igv-scrollbar-outer-width: 14px;
 const igv_scrollbar_outer_width = 14
@@ -141,6 +142,16 @@ class Browser {
             }
         })
 
+        this.on('willremovecolumn', column => {
+            if (trackViewportPopoverList.length > 0) {
+                const len = trackViewportPopoverList.length
+                for (let i = 0; i < len; i++) {
+                    trackViewportPopoverList[ i ].dispose()
+                }
+                trackViewportPopoverList.length = 0
+            }
+        })
+
         this.addMouseHandlers()
 
         this.sampleInfo = new SampleInfo(this)
@@ -1582,6 +1593,9 @@ class Browser {
         // find the $column corresponding to this referenceFrame and remove it
         const index = this.referenceFrameList.indexOf(referenceFrame)
         const {$viewport} = this.trackViews[0].viewports[index]
+
+        this.fireEvent('willremovecolumn', [ $viewport.parent().get(0) ]);
+
         viewportColumnManager.removeColumnAtIndex(index, $viewport.parent().get(0))
 
         for (let {viewports} of this.trackViews) {

js/trackViewport.js

@@ -17,7 +17,7 @@ let mouseDownCoords
 let lastClickTime = 0
 let lastHoverUpdateTime = 0
 let popupTimerID
-let globalPopoverList = []
+let trackViewportPopoverList = []
 
 let popover
 
@@ -775,11 +775,11 @@ class TrackViewport extends Viewport {
                                             popover.dispose()
                                         }
 
-                                        if (globalPopoverList.length > 0) {
-                                            for (const gp of globalPopoverList) {
+                                        if (trackViewportPopoverList.length > 0) {
+                                            for (const gp of trackViewportPopoverList) {
                                                 gp.dispose()
                                             }
-                                            globalPopoverList = []
+                                            trackViewportPopoverList.length = 0
                                         }
 
                                         popover = new Popover(this.$viewport.get(0).parentElement, true, undefined, () => {
@@ -790,12 +790,12 @@ class TrackViewport extends Viewport {
                                     } else {
 
                                         let po = new Popover(this.$viewport.get(0).parentElement, true, undefined, () => {
-                                            const index = globalPopoverList.indexOf(po)
-                                            globalPopoverList.splice(index, 1)
+                                            const index = trackViewportPopoverList.indexOf(po)
+                                            trackViewportPopoverList.splice(index, 1)
                                             po.dispose()
                                         })
 
-                                        globalPopoverList.push( po )
+                                        trackViewportPopoverList.push( po )
 
                                         po.presentContentWithEvent(event, content)
                                     }
@@ -892,12 +892,12 @@ class TrackViewport extends Viewport {
             this.popover.dispose()
         }
 
-        // if (globalPopoverList) {
-        //     for (let i = 0; i < globalPopoverList.length; i++ ) {
-        //         globalPopoverList[ i ].dispose()
+        // if (trackViewportPopoverList) {
+        //     for (let i = 0; i < trackViewportPopoverList.length; i++ ) {
+        //         trackViewportPopoverList[ i ].dispose()
         //     }
         //
-        //     globalPopoverList = undefined
+        //     trackViewportPopoverList = undefined
         // }
 
         super.dispose()
@@ -967,4 +967,5 @@ function mergeArrays(a, b) {
 
 }
 
+export { trackViewportPopoverList }
 export default TrackViewport