Skip to content

Commit a2aba67

Browse files
committed
Popover - TrackViewport - discard items properly
1 parent cc71edb commit a2aba67

File tree

2 files changed

+16
-4
lines changed

2 files changed

+16
-4
lines changed

js/trackViewport.js

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -869,6 +869,22 @@ class TrackViewport extends Viewport {
869869
return content
870870
}
871871

872+
dispose() {
873+
874+
if (this.popover) {
875+
this.popover.dispose()
876+
}
877+
878+
if (this.popoverList) {
879+
for (let i = 0; i < this.popoverList.length; i++ ) {
880+
this.popoverList[ i ].dispose()
881+
}
882+
883+
this.popoverList = undefined
884+
}
885+
886+
super.dispose()
887+
}
872888

873889
}
874890

js/viewport.js

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -192,10 +192,6 @@ class Viewport {
192192
*/
193193
dispose() {
194194

195-
if (this.popover) {
196-
this.popover.dispose()
197-
}
198-
199195
this.$viewport.get(0).remove()
200196

201197
// Null out all properties -- this should not be neccessary, but just in case there is a

0 commit comments

Comments
 (0)