From 510abd2f36f4f910002c0f7efa5b079789d7bd1c Mon Sep 17 00:00:00 2001 From: Jonathan Leitschuh Date: Tue, 4 Oct 2022 00:19:28 +0000 Subject: [PATCH] vuln-fix: Temporary Directory Hijacking or Information Disclosure This fixes either Temporary Directory Hijacking, or Temporary Directory Local Information Disclosure. Weakness: CWE-379: Creation of Temporary File in Directory with Insecure Permissions Severity: High CVSSS: 7.3 Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.UseFilesCreateTempDirectory) Reported-by: Jonathan Leitschuh Signed-off-by: Jonathan Leitschuh Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/10 Co-authored-by: Moderne --- .../locationdb/BDBResourceFileLocationDBTest.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/wayback-core/src/test/java/org/archive/wayback/resourcestore/locationdb/BDBResourceFileLocationDBTest.java b/wayback-core/src/test/java/org/archive/wayback/resourcestore/locationdb/BDBResourceFileLocationDBTest.java index b19829b72c..a3d7d82bda 100644 --- a/wayback-core/src/test/java/org/archive/wayback/resourcestore/locationdb/BDBResourceFileLocationDBTest.java +++ b/wayback-core/src/test/java/org/archive/wayback/resourcestore/locationdb/BDBResourceFileLocationDBTest.java @@ -21,6 +21,7 @@ import java.io.File; import java.io.IOException; +import java.nio.file.Files; import java.util.Iterator; import org.archive.wayback.resourcestore.locationdb.BDBResourceFileLocationDB; @@ -45,10 +46,10 @@ public class BDBResourceFileLocationDBTest extends TestCase { */ protected void setUp() throws Exception { - tmpFile = File.createTempFile("test-FileLocationDB",".tmp"); + tmpFile = Files.createTempDirectory("test-FileLocationDB" + ".tmp").toFile(); tmpLogFile = File.createTempFile("test-FileLocationDB",".log"); - assertTrue(tmpFile.delete()); - assertTrue(tmpFile.mkdirs()); + assertTrue(true); + assertTrue(true); dbPath = tmpFile.getAbsolutePath(); dbName = "test-FileLocationDB"; db = new BDBResourceFileLocationDB();