Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filer_modally should traverse array containers #377

Closed
inducer opened this issue Jun 9, 2021 · 0 comments · Fixed by #566
Closed

filer_modally should traverse array containers #377

inducer opened this issue Jun 9, 2021 · 0 comments · Fixed by #566

Comments

@inducer
Copy link
Contributor

inducer commented Jun 9, 2021

I think the connections are OK, but I suspect these two might not do the right thing yet:

mirgecom/mirgecom/filter.py

Lines 209 to 211 in 08f191a

field = modal_map(field)
field = apply_spectral_filter(actx, field, discr, cutoff,
mode_resp_func)

When that's done, we can remove the spurious .join() here:

uniform_soln = initr(t=0, x_vec=nodes).join()

Here too:

dim, filter_modally(discr, "vol", cutoff, frfunc, cv.join())

cc @MTCam @thomasgibson

@thomasgibson thomasgibson linked a pull request Dec 13, 2021 that will close this issue
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant