Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate unneeded empty arrays from ConservedVars #575

Open
MTCam opened this issue Dec 15, 2021 · 1 comment
Open

Eliminate unneeded empty arrays from ConservedVars #575

MTCam opened this issue Dec 15, 2021 · 1 comment

Comments

@MTCam
Copy link
Member

MTCam commented Dec 15, 2021

Empty arrays for multi-species placeholders are causing problems at multiple levels of the MIRGE software toolchain, are cumbersome, and difficult to get right. Let's eliminate them.

#569 closes this.
This was referenced Dec 15, 2021
Closed
Merged
@majosm
Copy link
Collaborator

majosm commented Dec 16, 2021

FWIW, I'm trying to see how much refactoring is necessary to make it work with CV as is in #579. Not quite there yet, but doesn't seem too bad so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Split CV illinois-ceesd/mirgecom
2 participants
@majosm @MTCam