Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux and macos binary updated to v2.2.0 #19

Closed
wants to merge 2 commits into from
Closed

linux and macos binary updated to v2.2.0 #19

wants to merge 2 commits into from

Conversation

adityapatadia
Copy link

@adityapatadia adityapatadia commented Jan 2, 2019

This closes #18

@adityapatadia adityapatadia changed the title macos binary updated to v2.2.0 linux and macos binary updated to v2.2.0 Jan 2, 2019
@adityapatadia
Copy link
Author

@1000ch can you merge this?

@sindresorhus
Copy link
Contributor

@adityapatadia Sorry, we don't accept binary submissions from random people as we can't trust those binaries. One of the maintainers will need to update the binaries. You also incorrectly changed the permission of one of the binaries.

@adityapatadia
Copy link
Author

Okay. It would be great if someone can update the binaries. It takes just few minutes to compile but will give users improved binaries. Current ones date back to 2015.

@adityapatadia
Copy link
Author

I had this thought. Is it possible I can build binary in say some docker container or say travis CI kind of system and submit along with its MD5 hash so that it's guaranteed to be authentic?

@adityapatadia
Copy link
Author

@sindresorhus what do you think is best way to update the binaries? I need to get them updated.

@kevva
Copy link
Contributor

kevva commented Sep 10, 2019

@adityapatadia, I will update them. I'm looking into a solution so that users can fall back to existing binaries on their system.

@adityapatadia
Copy link
Author

Is there a specific reason to keep those 4 year old binaries?

May be we can just tag new version and write in readme to use older version for those binaries.

@kevva
Copy link
Contributor

kevva commented Sep 10, 2019

There's no particular reason. I just haven't been as active to keep them updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update binaries
3 participants