From eed23b4f754eec13c7a612424d5135245c98d4ca Mon Sep 17 00:00:00 2001 From: Ermyas Abebe Date: Tue, 29 Apr 2025 11:35:27 +1000 Subject: [PATCH 1/4] Update HLA doc --- docs/high-level-architecture.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/high-level-architecture.md b/docs/high-level-architecture.md index 2490e448..9c16781a 100644 --- a/docs/high-level-architecture.md +++ b/docs/high-level-architecture.md @@ -36,7 +36,7 @@ ## Introduction ### Purpose -This document outlines a high-level architecture and threat model for the token bridge between Ethereum ("Root" chain) and the Immutable zkEVM ("Child" chain) chains. The bridge facilitates the transfer of ETH, IMX, and standard ERC20 tokens between these chains, using an underlying General Message Passing (GMP) bridge, Axelar, for message transmission. This bridge is a critical piece of infrastructure for the Immutable zkEVM chain, that will potentially custody significant amount of user assets. +This document outlines a high-level architecture and threat model for the token bridge between Ethereum ("Root" chain) and the Immutable zkEVM ("Child" chain) chains. The bridge facilitates the transfer of ETH, IMX, and standard ERC20 tokens between these chains, using an underlying General Message Passing (GMP) bridge, Axelar, for message transmission. This bridge is a critical piece of infrastructure for the Immutable zkEVM chain. The purpose of this document is to two-fold: 1. Provide a high-level view of the Immutable zkEVM bridge's architecture, in terms of its core functionalities and use-cases, major components and their interactions, dependencies and architectural characteristics. From dc4233b3aeceaaba5342ebf8ffb75e7dc45632ee Mon Sep 17 00:00:00 2001 From: Ermyas Abebe Date: Tue, 29 Apr 2025 12:15:18 +1000 Subject: [PATCH 2/4] Fix issue resulting from upgrade to Foundry v1 --- foundry.toml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/foundry.toml b/foundry.toml index 0e7d2ae8..ced17720 100644 --- a/foundry.toml +++ b/foundry.toml @@ -5,4 +5,5 @@ libs = ["lib"] solc-version = "0.8.19" # Reason for why this flag is required can be found here: https://github.com/foundry-rs/foundry/issues/7607 unchecked_cheatcode_artifacts = true -# See more config options https://github.com/foundry-rs/foundry/blob/master/crates/config/README.md#all-options \ No newline at end of file +# Reasons for why this flag is required can be found here: https://book.getfoundry.sh/cheatcodes/expect-revert#description +allow_internal_expect_revert = true \ No newline at end of file From 5a23fa3eefacd0c5d9f94a8add7e1a862bcda6a4 Mon Sep 17 00:00:00 2001 From: Ermyas Abebe Date: Tue, 29 Apr 2025 12:47:48 +1000 Subject: [PATCH 3/4] Fix breaking change from Foundry v1 Foundry v1 disables optimizer by default. Hence, this commit enables this: https://book.getfoundry.sh/guides/v1.0-migration#solc-optimizer-disabled-by-default --- foundry.toml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/foundry.toml b/foundry.toml index ced17720..d768a863 100644 --- a/foundry.toml +++ b/foundry.toml @@ -6,4 +6,7 @@ solc-version = "0.8.19" # Reason for why this flag is required can be found here: https://github.com/foundry-rs/foundry/issues/7607 unchecked_cheatcode_artifacts = true # Reasons for why this flag is required can be found here: https://book.getfoundry.sh/cheatcodes/expect-revert#description -allow_internal_expect_revert = true \ No newline at end of file +allow_internal_expect_revert = true +# Required because of a breaking change in Foundry v1, which disabled optimizer by default: https://book.getfoundry.sh/guides/v1.0-migration#solc-optimizer-disabled-by-default +optimizer = true +optimizer_runs = 200 \ No newline at end of file From 609230f0217ea16363c8e5b6e438d8a87b1e055e Mon Sep 17 00:00:00 2001 From: Ermyas Abebe Date: Tue, 29 Apr 2025 13:22:24 +1000 Subject: [PATCH 4/4] Fix CI Workflow Error --- .github/workflows/coverage.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml index fd3d459b..edb82ff2 100644 --- a/.github/workflows/coverage.yml +++ b/.github/workflows/coverage.yml @@ -19,6 +19,11 @@ jobs: with: submodules: recursive + - name: Set Node.js 18.18.x + uses: actions/setup-node@v3 + with: + node-version: 18.18.x + - name: Restore node modules from cache uses: ./.github/actions/node-cache