Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-uniform filter naming #502

Open
piconti opened this issue Jan 29, 2025 · 5 comments
Open

Non-uniform filter naming #502

piconti opened this issue Jan 29, 2025 · 5 comments

Comments

@piconti
Copy link
Member

piconti commented Jan 29, 2025

In the main search section, when selecting filters, there are both full text capitalized names (Swiss National Library, Luxembourg) and short acronyms within quotes ("BCUL", "FR").
It's really not a big deal but maybe it's easy to uniformize

Image
@theorm
Copy link
Member

theorm commented Feb 5, 2025

@piconti until now these labels have been hardcoded in the translation file in the front end code. It would be great to load this dynamically from Solr or the database or some well known location on GitHub. Are you aware of any place where all these labels can be found?

@piconti
Copy link
Member Author

piconti commented Feb 6, 2025

Hmm Just realized that indeed there is no file containing this for you, I will check the DB.
I could add it without too much problems inside the access rights catalogue, would that be helpful? or should it be somewhere else??

@theorm
Copy link
Member

theorm commented Feb 7, 2025

@piconti what is access rights catalogue?
As long as it's somewhere where we can access programmatically and is in a machine readable form (key/value) it's not a problem for us to access. Solr, DB or a publicly accessible file on the internet is totally fine. We will be caching it so performance is not an issue.

@piconti
Copy link
Member Author

piconti commented Feb 7, 2025

This.
Where all the access rights are listed for each title period.
There we could put the full institution name.
But maybe that's not the ideal place, and then we could put it somewhere else.

@theorm
Copy link
Member

theorm commented Feb 8, 2025

How about we add another file to this directory with institution code/name pairs. We can then load and cache this file in IML directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants