Merge pull request #97 from in2code-pro/improve-compatibility-with-sql-modes

[BUGFIX] Improve compatibility with sql modes

Author: mschwemer

Classes/Condition/PowermailConditionFunctionsProvider.php

@@ -70,14 +70,17 @@ protected function isPowermailSubmittedFunction(): ExpressionFunction
      */
     protected function isPluginExistingOnCurrentPageInCurrentLanguage(array $plugins): bool
     {
-        $listTypes = implode('","', $plugins);
+        $listTypes = implode('\',\'', $plugins);
         $queryBuilder = DatabaseUtility::getQueryBuilderForTable('tt_content');
         $row = $queryBuilder
             ->select('*')
             ->from('tt_content')
-            ->where('pid=' . FrontendUtility::getCurrentPageIdentifier()
-                . ' and CType in ("' . $listTypes . '") and sys_language_uid='
-                . FrontendUtility::getSysLanguageUid())->setMaxResults(1)->executeQuery()
+            ->where(
+                'pid=' . FrontendUtility::getCurrentPageIdentifier()
+                . ' and CType in (\'' . $listTypes . '\') and sys_language_uid='
+                . FrontendUtility::getSysLanguageUid()
+            )->setMaxResults(1)
+            ->executeQuery()
             ->fetchAssociative();
         return !empty($row['uid']);
     }

Classes/Domain/Repository/FieldRepository.php

@@ -106,7 +106,7 @@ public function findAllWrongLocalizedFields(): array
         $rows = $queryBuilder
             ->select('uid', 'pid', 'title', 'l10n_parent', 'sys_language_uid')
             ->from(Field::TABLE_NAME)
-            ->where('(page = "" or page = 0) and sys_language_uid > 0 and deleted = 0')
+            ->where('(page = \'\' or page = 0) and sys_language_uid > 0 and deleted = 0')
             ->executeQuery()
             ->fetchAllAssociative();
         foreach ($rows as $row) {

Classes/Domain/Repository/FormRepository.php

@@ -149,7 +149,7 @@ public function findAllWrongLocalizedForms(): array
 
         $sql = 'select uid,pid,title';
         $sql .= ' from ' . Form::TABLE_NAME;
-        $sql .= ' where pages = ""';
+        $sql .= ' where pages = \'\'';
         $sql .= ' and sys_language_uid > 0';
         $sql .= ' and deleted = 0';
         $sql .= ' limit 1';
@@ -167,7 +167,7 @@ public function fixWrongLocalizedForms(): void
         $queryBuilder = DatabaseUtility::getQueryBuilderForTable(Form::TABLE_NAME);
         $queryBuilder
             ->update(Form::TABLE_NAME)
-            ->where('sys_language_uid > 0 and deleted = 0 and pages = ""')
+            ->where('sys_language_uid > 0 and deleted = 0 and pages = \'\'')
             ->set('pages', 0)
             ->executeStatement();
     }
@@ -182,7 +182,7 @@ public function fixWrongLocalizedForms(): void
     public function getFieldsFromFormWithSelectQuery(int $formUid): array
     {
         $queryBuilder = DatabaseUtility::getQueryBuilderForTable(Field::TABLE_NAME, true);
-        $where = 'f.deleted = 0 and f.hidden = 0 and f.type != "submit" and f.sys_language_uid IN (-1,0)' .
+        $where = 'f.deleted = 0 and f.hidden = 0 and f.type != \'submit\' and f.sys_language_uid IN (-1,0)' .
             ' and fo.uid = ' . (int)$formUid;
         return $queryBuilder
             ->select('f.uid', 'f.title', 'f.sender_email', 'f.sender_name', 'f.marker')

Classes/Domain/Repository/PageRepository.php

@@ -77,7 +77,7 @@ public function findAllWrongLocalizedPages(): array
         return $queryBuilder
             ->select('uid', 'pid', 'title', 'l10n_parent', 'sys_language_uid')
             ->from(Page::TABLE_NAME)
-            ->where('(form = "" or form = 0) and sys_language_uid > 0 and deleted = 0')
+            ->where('(form = \'\' or form = 0) and sys_language_uid > 0 and deleted = 0')
             ->executeQuery()
             ->fetchAllAssociative();
     }

Classes/Utility/DatabaseUtility.php

@@ -105,7 +105,7 @@ public static function isFieldFilled(string $fieldName, string $tableName): bool
             return (int)$queryBuilder
                     ->count($fieldName)
                     ->from($tableName)
-                    ->where($fieldName . ' != "" and ' . $fieldName . ' != 0')
+                    ->where($fieldName . ' != \'\' and ' . $fieldName . ' != 0')
                     ->executeQuery()
                     ->fetchOne() > 0;
         }

Classes/ViewHelpers/Be/PowermailVersionNoteViewHelper.php

@@ -123,7 +123,7 @@ protected function isCurrentVersionUnsafeCheck(): bool
         $row = $queryBuilder
             ->select('review_state')
             ->from(self::TABLE_NAME)
-            ->where('extension_key = "powermail" and version = "' . $this->getVersion() . '"')
+            ->where('extension_key = \'powermail\' and version = \'' . $this->getVersion() . '\'')
             ->setMaxResults(1)
             ->executeQuery()
             ->fetchOne();
@@ -143,7 +143,7 @@ protected function isNewerVersionAvailableCheck(): bool
         $row = $queryBuilder
             ->select('version')
             ->from(self::TABLE_NAME)
-            ->where('extension_key = "powermail"')
+            ->where('extension_key = \'powermail\'')
             ->orderBy('version', 'desc')
             ->setMaxResults(1)
             ->executeQuery()
@@ -167,7 +167,7 @@ protected function isCurrentVersionInExtensionTableExistingCheck(): bool
         $row = $queryBuilder
             ->select('uid')
             ->from(self::TABLE_NAME)
-            ->where('extension_key = "powermail" and version = "' . $this->getVersion() . '"')
+            ->where('extension_key = \'powermail\' and version = \'' . $this->getVersion() . '\'')
             ->setMaxResults(1)
             ->executeQuery()
             ->fetchOne();