Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version does not show flash messages (e.g. on error sending email) #1087

Open
sypets opened this issue Jul 23, 2024 · 3 comments
Open

Comments

@sypets
Copy link
Contributor

sypets commented Jul 23, 2024

reproduce

  1. added all TypoScript static includes
  2. created a form
  3. in Frontend send form
  4. via Debugger in FormController:: line 385, set $isSent to false
  5. $this->addFlashMessage( is then called, but no flash message displayed in frontend
$isSent = $mailPreflight->sendReceiverMail($mail, $hash);
if ($isSent === false) {

$isSent = $mailPreflight->sendReceiverMail($mail, $hash);

reason

  • the partial FlashMessages is called, but
  • the identifier of the FlashMessageQueue is set as (in ActionController):

$identifier = 'extbase.flashmessages.' . $pluginNamespace;

which evaluates to

'extbase.flashmessages.tx_powermail_pi1'

but the partial uses:

<f:flashMessages queueIdentifier="powermail"/>

If we change it to

<f:flashMessages queueIdentifier="extbase.flashmessages.tx_powermail_pi1"/>

the messages are displayed (but not styled).

versions

  • TYPO3: latest 12.4 (12.4 branch)
  • powermail: 12.3.5 (rechecked with latest master/ main, has same problem)
  • Composer installation: no
  • PHP: 8.2
mschwemer added a commit that referenced this issue Aug 1, 2024
Related: #1087
Signed-off-by: Marcus Schwemer <marcus.schwemer@in2code.de>
@mschwemer
Copy link
Collaborator

Thanks for your report. The fix is available in the feature-branch and will be included in one of the next releases.

The styling is up to the fe developers.

If you need a styling, you can copy the alert classes from bootstrap in Resources/Private/Build/Sass/_BootstrapExpanded.scss to your stylesheet.

I will leave it open, until the release is out.

@mschwemer
Copy link
Collaborator

PR merged

@mschwemer
Copy link
Collaborator

Needed to revert the PR, because other flash messages were not shown and the form delivered a wrong result.

See the behaviour tests without Typoscript

@mschwemer mschwemer reopened this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants