Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make bazinga as optional field by config #78

Open
vkatsuba opened this issue Nov 23, 2021 · 0 comments
Open

Make bazinga as optional field by config #78

vkatsuba opened this issue Nov 23, 2021 · 0 comments
Labels
backlog 👁️ Backlog discussion ⏰ Discussion feature 🚀 Feature Request

Comments

@vkatsuba
Copy link
Collaborator

sheldon version

0.3.0

OS version

Ubuntu

Description

  • Motivation
    Not all users want to see bazinga in response from sheldon. It would be great have configuration for this behavior.
  • Proposal
    Add new config option show_bazinga true/false to skip bazinga message from sheldon in response.

Current behavior

The bazinga field in response always provided.

Expected behavior

The bazinga field in response should be configurable.
@vkatsuba vkatsuba added discussion ⏰ Discussion feature 🚀 Feature Request backlog 👁️ Backlog labels Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog 👁️ Backlog discussion ⏰ Discussion feature 🚀 Feature Request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vkatsuba