feat: Refactor gas-optimized tx path for Ledger (refactor/gas-827-1) #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes introduce a streamlined transaction encoding path and centralized gas accounting for Ledger-supported flows. Key updates include:
Gas trade-offs:
This refactor targets lower gas usage by avoiding repeated reads and by moving invariant computations out of hot paths. The trade-off is a slightly larger initial function footprint and increased complexity in the signer path, which may affect readability. When used in conjunction with the existing ledger optimization, total gas per tx should decrease on common paths, while some atypical flows may see marginal increases due to new inline checks. Overall, expected net gas savings should be observable across bulk-tx scenarios and higher-volume deployments.