CInfClassGameController::SortCharactersByDistance: Sort exactly once

Kaffeine · Kaffeine · commit d7ad391765e2 · 2024-07-27T22:56:22.000+03:00
diff --git a/src/game/server/infclass/infcgamecontroller.cpp b/src/game/server/infclass/infcgamecontroller.cpp
@@ -2418,10 +2418,10 @@ void CInfClassGameController::SortCharactersByDistance(const ClientsArray &Input
 			continue;
 
 		Distances.Add(DistanceItem(ClientId, Distance));
-
-		std::sort(Distances.begin(), Distances.end());
 	}
 
+	std::sort(Distances.begin(), Distances.end());
+
 	pOutput->Clear();
 	for(const DistanceItem &DistanceItem : Distances)
 	{

Original file line number	Diff line number	Diff line change
`@@ -2418,10 +2418,10 @@ void CInfClassGameController::SortCharactersByDistance(const ClientsArray &Input`
`2418`	`2418`	`continue;`
`2419`	`2419`
`2420`	`2420`	`Distances.Add(DistanceItem(ClientId, Distance));`
`2421`		`-`
`2422`		`- std::sort(Distances.begin(), Distances.end());`
`2423`	`2421`	`}`
`2424`	`2422`
	`2423`	`+ std::sort(Distances.begin(), Distances.end());`
	`2424`	`+`
`2425`	`2425`	`pOutput->Clear();`
`2426`	`2426`	`for(const DistanceItem &DistanceItem : Distances)`
`2427`	`2427`	`{`